Comments (2)
Hello @suhr! Thanks for your issue submission!
I am constantly working on improving the error handling concept. Unfortunately, I have no idea how to handle the error you reported as it is a numerical error which can occur at too many locations.
My strategy was to report all regular errors via Result
and all numerical errors via .expect("...")
. Do you have a good idea how numerical errors should be handled?
from tune.
I am closing this issue with the following outcome:
Ratio
operations no longer panic (to be released with tune-0.25.0). As a result, invalid float values (e.g. negative ones) are accepted by the API and can lead to non-finite (-inf, +inf, NaN) cents values. This is acceptable since all values passed to the API - including finite ones - need to be correct anyway.- API code using
expect
in newer modules is expected to be rewritten without panics and with type-level numerical checks soon. - Panics in executable code are okay.
- Code using
unwrap
is expected to never crash. If it does nonetheless, this is considered a bug. - If a panic is observed in the API code, this is considered bug.
from tune.
Related Issues (20)
- Apply live retuning in microwave HOT 3
- Add rotary effect control over MIDI HOT 1
- Audio-in HOT 1
- Add modular effects chain HOT 1
- Add live interactions with waveforms HOT 1
- Add ANSI Keyboard support HOT 4
- Pre-render sin function to array
- Use f32 instead of f64 in modular synth chain HOT 2
- tune scale documentation HOT 9
- Library vision (tracking issue)
- Named waveform buffers
- Split LfSource into a spec and state object HOT 1
- Add benchmarks HOT 1
- Remove DC offset / Implement DC filter
- Microwave requires Vulkan-compatible graphics HOT 7
- StreamConfigNotSupported error on Windows HOT 2
- MIDI in leaves GUI artefacts HOT 8
- Error on build HOT 2
- Add adaptive tuning
- ItemOutOfRange error generated on import. HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tune.