Comments (2)
Yea I've seen this happen too, very curious bug, no idea how/why it happens, I first noticed it in pre-patch where all the currencies became "Korrak's Revenge" - #7 - i'll keep an eye out.
from broker_currencyflow.
I have a fix for this - you're referencing a variable "name" that is never set in Currencyflow:LoadCurrencies().
I also refactored the function a bit to do what you were doing already but with considerably less repetition of the code.
See below.
-- This function tries to update the currencies list with client info
function Currencyflow:LoadCurrencies()
for id,currency in pairs(tracking) do
local name, icon
if currency.type == TYPE_CURRENCY then
local currencyInfo = C_CurrencyInfo.GetCurrencyInfo(id)
if currencyInfo ~= nil then
name = currencyInfo.name
icon = currencyInfo.iconFileID
end
elseif currency.type == TYPE_ITEM then
name, _, _, _, _, _, _, _, _, icon, _ = GetItemInfo(id)
elseif currency.type == TYPE_FRAGMENT then
local name, icon, _, _ = GetArchaeologyRaceInfo(currency.index)
-- Another dumb marvel of blizz consistency. When info
-- is not available, instead of returning nil or "",
-- this one puts "UNKNOWN" in the name.... sigh...
if icon == nil or icon == "" then
name = nil
end
end
if name ~= nil and name ~= "" then
currency.name = name
else
currency.name = "|cff999999"..currency.name.."|r"
end
if icon ~= nil and icon ~= "" then
currency.icon = icon
else
currency.icon = ICON_QM
end
end
end
from broker_currencyflow.
Related Issues (17)
- ShadowLands: attempt to call global 'GetCurrencyInfo' (a nil value) HOT 9
- Add tooltips to column headers in LDB display
- Currency not sorting
- CurrecyFlow tooltip not working in 9.1.5 HOT 5
- Request: Add these currencies please. HOT 6
- Cyphers of the First Ones & Cosmic Flux & Cataloged Research & Motes of Fate HOT 1
- Can the 9.2 (ZM) currencies be added? HOT 8
- Request - Add Year to History
- Column headers in tooltip are misaligned
- Any chance the new Dragonflight currencies can be added?
- Error message with 10.2.7 HOT 1
- Request: Add comma separator for larger numbers HOT 1
- v1.8.1 Broker problem with Elvui + S&L Datatext HOT 3
- Korrak's Revenge HOT 1
- errors with v1.7.5 HOT 1
- Request - Hide Silver and Copper
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from broker_currencyflow.