Allow clusters to include other clusters and not just hosts about i2cssh HOT 5 CLOSED

I like the idea, but what should the grouping for tabs be in case we specify -t or -T? Do the included clusters get their own tab or are all hosts just included in the list of hosts (as per your example)? Do we just want to include the hosts from the other cluster, or do we want to respect the cluster options (like login, shell, etc) from the included cluster as well?

from i2cssh.

If we start to consider options or tab groupings for included clusters, the complexity spirals out of control. And you would most likely only want the superset options. For example, the rows & columns specifications of a sub-cluster should not be applied to the superset!

Also, this will then give you the ability to apply different sets of settings against the same hosts by having multiple super-clusters including the same sub-cluster.

from i2cssh.

Exactly. So what we could do (as your PR does) is to just include the hosts of a different cluster and don't worry about the settings of the other cluster. I kind of like that idea, because that basically gives you the opportunity to connect to a group of hosts in different ways (different login, different shell, etc).

I will add a different header in the config (like include_hosts_from_cluster) or something, to make the configuration explicit, rather than having "special" hosts that are actually clusters. I'll not make this recursive for now, since the user has the opportunity to explicitly add one or more clusters.

from i2cssh.

I've uploaded version 0.0.11 that has the option include_from. This is only enabled as a parameter in the config file. Let me know what you think.

from i2cssh.

I'm happy with the include_from keyword, although I'm not personally inclined to cater for people who use the same name for a cluster as they do for a hostname!

One small fix to allow for a cluster to not have a hosts section:

382c382
<         host_strings = config["clusters"][cluster_name].get("hosts", [])
---
>         host_strings = config["clusters"][cluster_name]["hosts"]

from i2cssh.