Giter Club home page Giter Club logo

Comments (7)

natema avatar natema commented on September 25, 2024

We should test what we get if we solve the system like them, i.e. with a simple Euler method with fixed step size of 5 years.

from worlddynamics.jl.

universmile avatar universmile commented on September 25, 2024

The solution returned by the Euler solver is noisy.

The changes have been made under solvesystems.jl in the following manner (corresponding to the first plot below) :

function solve(system::ODESystem, timespan; solver=Euler())
    sys = structural_simplify(system)

    prob = ODEProblem(sys, [], timespan)
    sol = ModelingToolkit.solve(prob, solver, dt = 5)

    return sol
end

Fixed step size of 5 :

Fig  7 38_euler5

Fixed step size of 50 :

Fig  7 38_euler_50

from worlddynamics.jl.

natema avatar natema commented on September 25, 2024

Yes, @piluc and I also verified this independently.
Now @piluc and @paulobruno are looking into this.

from worlddynamics.jl.

natema avatar natema commented on September 25, 2024

There must be an error in the book, since our Figure agrees with the one of pyworld3.

from worlddynamics.jl.

paulobruno avatar paulobruno commented on September 25, 2024

To illustrate what @natema mentioned, here is the comparison of fig 7.38.

World3 WorldDynamics.jl PyWorld3
world3 worlddynamics pyworld3

from worlddynamics.jl.

paulobruno avatar paulobruno commented on September 25, 2024

Since the general agreement is that our code is now returning the correct plot, I'm closing this issue.

from worlddynamics.jl.

natema avatar natema commented on September 25, 2024

For future reference, the same mismatch is present in Figure 7.39 as well.

from worlddynamics.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.