Extract `storage.js` into own package about workshopper-adventure HOT 18 CLOSED

Made you admin!

from workshopper-adventure.

I refactored and wrote some tests and documentation. Module is living here: https://github.com/kid-icarus/webshopper-adventure-storage

The one thing to note is I changed all the methods to be async. Let me know if there's anything else you'd like to see here, and I can make a PR to use it.

from workshopper-adventure.

@kid-icarus This is awesome, thank you for your work! I opened a few issues in the repository that would be lovely if they could be addressed. Particularly the interoperation with older versions of Node might be a biggie. Even though future versions of Workshopper it might be worth considering to drop old node.js version support, I think it might be a bit early for this discussion. I saw that you are using arrow functions that are supported from Version 5 but 4 is still the LTS branch (so it will be around for a while longer).

from workshopper-adventure.

@kid-icarus Thank you for the 1.0.0 release of workshopper-adventure-storage. i agree that the asynchronous API is not a bad thing but it will take a little to adopt all the code.

from workshopper-adventure.

@kid-icarus how would you feel about moving that repo into the workshopper org?

from workshopper-adventure.

@SomeoneWeird I'd gladly transfer it over 😄 could I possibly be added to the org?

from workshopper-adventure.

@kid-icarus Invitation sent!

from workshopper-adventure.

Thanks @martinheidegger, glad to be a member of the org!

I tried to transfer ownership to workshopper but got this message, not sure why I need admin access 😕

I'll take a closer look after work.

from workshopper-adventure.

I just tried to transfer ownership, but still encountering the same message. I'm not sure what other permission I need 😕

from workshopper-adventure.

Can you try again?

from workshopper-adventure.

I just tried to transfer again, got the same message. I might have to be owner of the org to transfer ownership. It doesn't matter to me if I have that role permanently but it might be worth switching me for a minute while I transfer unless I'm missing something obvious.

from workshopper-adventure.

Now you have master privileges. (Note: sorry for my incompetence. I will read more into github org priliveges but now everything should be possible for you)

from workshopper-adventure.

No worries, they added a lot of new features and permissions recently, I'm also not caught up with it all :)

@SomeoneWeird I went ahead and transferred it over, let me know if there's anything I've missed (I granted access to all members of the workshopper Core team)

from workshopper-adventure.

I think this can be closed now per 0fbda0d

from workshopper-adventure.

Sadly, no. After publishing I recognized that the workshopper-adventure-storage(w-a-s) doesn't seem to work in some cases and I had to, unfortunately, unpublish the workshopper-adventure with the integration. (w-a-s has a problem if the folder it wants to store configuration in doesn't exist)

Tonight it is on the top of my priority list to write a proper issue report / PR.

from workshopper-adventure.

Oh no! I'll create an issue and promptly fix.

from workshopper-adventure.

workshopper/workshopper-adventure-storage#9

from workshopper-adventure.

Okay, this should do the trick, published 5.1.6 as latest version that should include [email protected] 🍾

from workshopper-adventure.