Option for using ObjectLiteral or else to allow Entities not extended from BaseEntity about nestjs-library-crud HOT 5 CLOSED

I found the use of the Active Record Pattern in the code.

This will be fixed in #377

and I am checking can apply ObjectLiteral not EntitySchema

from nestjs-library-crud.

hi tkahng

Right
It is not using ActiveRecord Pattern, so there is no problem with not extended from BaseEntity.

The BaseEntity Type is being simply used for the purpose that is Entity.

It can use EntitySchema instead of BaseEntity. how is it?

from nestjs-library-crud.

you mean like

export class CrudService<T extends EntitySchema<T>> {

never used EntitySchema, but doing a quick test it doesnt seem to work wit regular entities. or am i misunderstanding what you said?

I was thinking what nestjsx/crud did would be fine.

export declare class TypeOrmCrudService<T> extends CrudService<T, DeepPartial<T>> {

where T extends ObjectLiteral

and anything they needed for the Entity, like columns, relations was through the repo:

protected get entityType(): ClassType<T> { return this.repo.target as ClassType<T>; }

not sure if this would be an easy task from a quick look at the source. what do you think of this?

from nestjs-library-crud.

I don't like that it forces type casting in some code,
but this could be improved with future refactoring.

#384

import { ObjectLiteral } from 'typeorm';

export type EntityType = ObjectLiteral;

from nestjs-library-crud.

resolved in 0.9.0

from nestjs-library-crud.