Comments (4)
@TravisSperry yep, we need to encode that. Feel free to submit a Pull Request if you have some free time. I'll try fix it on the weekend.
from wc-api-ruby.
It looks like they are being encoded in add_query_params...
endpoint + URI.encode(flatten_hash(data).join('&'))
Is the correct fix...
URI.encode(endpoint + flatten_hash(data).join('&')) ?
from wc-api-ruby.
The problem is actually in how the params are encoded for the oauth signature. Spaces aren't handled correctly. This happens regardless of whether you use a params hash or just pass a query_string. So the same problem occurs for
response = woocommerce.get("products?filter[category]=String+With+Spaces")
In oauth.rb, the encode_param method needs to be changed to:
CGI::escape(text).gsub('+', '%20').gsub("%", "%25")
I'll submit a pull request with the fix.
from wc-api-ruby.
Thanks for the clarification.
Travis SperryDirector of IT
Math Plus Academy
O: 614.792.6284
C: 614.260.6162
Schedule a complimentary assessment:
http://www.mathplusacademy.com/book-assessment
On Wed, Dec 2, 2015 at 10:00 PM, Daniel Hoey [email protected]
wrote:
The problem is actually in how the params are encoded for the oauth signature. Spaces aren't handled correctly. This happens regardless of whether you use a params hash or just pass a query_string. So the same problem occurs for
response = woocommerce.get("products?filter[category]=String+With+Spaces")
In oauth.rb, the encode_param method needs to be changed to:
CGI::escape(text).gsub('+', '%20').gsub("%", "%25")
I'll submit a pull request with the fix.
Reply to this email directly or view it on GitHub:
#14 (comment)
from wc-api-ruby.
Related Issues (20)
- Filtering order notes HOT 1
- Update an order line_items meta HOT 1
- Can't update a products tags or attributes via API HOT 1
- JSON Parse Error on GET HOT 2
- Can't authenticate
- JSON Parse error HOT 3
- List all customers filter parameters are not working HOT 5
- require "woocommerce_api" gives error "cannot load such file -- woocommerce_api" HOT 3
- API Documentation and Behavior Mismatch HOT 1
- API v1 - Unable to get current store details in Ruby HOT 1
- 400 bad request HOT 1
- Accessing x-wp-total and x-wp-totalpages fails on this particular account HOT 1
- how to make update requests HOT 2
- Deleting a webhook, ruby doc incorrect?
- Getting products with variation details in bulk? HOT 1
- cannot update products/categories
- Add metadata to existing coupon
- REST API Documentation refers to "wp_json" option instead of "wp_api", yielding confusing results.
- URI.encode is obsoleted and not available in the latest Ruby versions HOT 4
- How could I use proxy to call an APIs HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wc-api-ruby.