Giter Club home page Giter Club logo

Comments (5)

claudiosanches avatar claudiosanches commented on July 17, 2024

Index works because don't need any authentication.

To V3 is not possible to pass keys as query string, I recommend you use oAuth in this case.
Maybe we can do something to force use oAuth even when the URL is over SSL.

from wc-api-ruby.

choubacha avatar choubacha commented on July 17, 2024

Hmm, the query string is working for me on woo 2.4.7 with v3 passed into the client gem.

Will oauth work even if it's https? Should we make an option to force oauth in the gem?

from wc-api-ruby.

claudiosanches avatar claudiosanches commented on July 17, 2024

Yep, oAuth can work with https and yep, I agree, will be great have some option for it.

And sorry, I had misunderstood:

It does work if I include the secret and key in the query params.

The problem is the server unable to configure PHP_AUTH_USER and PHP_AUTH_PW.

Here how this works: https://github.com/woothemes/woocommerce/blob/master/includes/api/class-wc-api-authentication.php#L79-L93

See that we test for the query strings first as fallback and then we try PHP vars.

from wc-api-ruby.

choubacha avatar choubacha commented on July 17, 2024

@claudiosmweb

Thanks for sending me the link to the location in woocommerce code that this relates to. It looks like woo never tries to do oauth over ssl:

https://github.com/woothemes/woocommerce/blob/master/includes/api/class-wc-api-authentication.php#L45-L49

I have a change on my fork that will allow a client to always use oauth but I don't think that will work until ssl is able to read the oauth params.

from wc-api-ruby.

claudiosanches avatar claudiosanches commented on July 17, 2024

Closing since need to use Basic Auth over SSL.

from wc-api-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.