Giter Club home page Giter Club logo

Comments (4)

robiso avatar robiso commented on May 13, 2024

Can you give a more accurate example, possibly live/web? I don't quite understand when the div or p tag pops out, since you're supposed to wrap editable areas in their own div tags. Does this happen with a custom theme or vanilla WonderCMS installation without any additional plugins?

As far as I understand the problem, this doesn't happen with regular content, but only the extra editable blocks? Or all editable blocks in general? I'm testing out all possible variations and the only time something saves wrong and becomes in-editable is when you're editing the HTML inside the editable blocks and close any of your code incorrectly.

An example of your code/site or when this happens will greatly help.

from wondercms.

scsmash3r avatar scsmash3r commented on May 13, 2024

To reproduce that kind of problem, the steps are:

  1. Install WonderCMS
  2. Go to theme.php
  3. On line 42 wrap <?=wCMS::page('content')?> into <p><?=wCMS::page('content')?></p>
  4. See the result

In my own theme, I have some misc content (like item prices) wrapped around with a <p> tag. And if I try to store something, that is starting with a block element in my content section, this will cause a bug.

The problem goes with all editable blocks in general.

from wondercms.

robiso avatar robiso commented on May 13, 2024

Thank you very much for the clear explanation.

I've tested out a fixed (unpublished) version pasted below. Can you please do a short test and replace the below index.php with your index.php or just create an extra folder (to avoid you overriding any files) on your server to test this out until we push an official fix.

What I changed in the index.php core file is changed the structure from spans to divs. Please report back as I couldn't break the editor any more in the way you described with the fix below.

If all tests go ok, we'll push a fix accordingly and credit your bug report and assistance. Please note this index.php below is not for production use and is only for testing purposes.

index.php.zip

from wondercms.

robiso avatar robiso commented on May 13, 2024

Fix pushed with version 2.0.3. You have been also publicly credited at the following locations:

from wondercms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.