Giter Club home page Giter Club logo

Comments (7)

wimleers avatar wimleers commented on June 3, 2024

Of course, this seems like an XDebug 3.3.0 regression. But if this a known issue, perhaps it'd be wise to hold off to reduce ecosystem impact?

from php.

csandanov avatar csandanov commented on June 3, 2024

Hi, as I understand your main issue is that xdebug was enabled because of PHP_XDEBUG=0 (the env var should be unset) and despite PHP_XDEBUG_MODE=off it still affected your build (maybe should be reported at https://bugs.xdebug.org/)

I recommend using this image with the stability tag, e.g. wodby/php:8.1-dev-4.40.9

from php.

wimleers avatar wimleers commented on June 3, 2024

Thank you! I tried that a minute before I saw your message here — and did it wrong 😅

Did what you suggested 👍

In the 30 mins since reporting this, somebody in Drupal pointed me to https://www.drupal.org/project/drupal/issues/3405976, where this is apparently a thing affecting all Drupal versions but only in certain XDebug modes. Derick himself is present in helping getting this sorted out.

Thanks for the incredibly fast response! 🤯 🙏 😊

from php.

wimleers avatar wimleers commented on June 3, 2024

Ah, but looks like I can't just do wodby/php:$_TARGET_PHP-dev-4.40.9 because that won't work for PHP 7.4, which I still need to test. Result: Docker failures.

So back to figuring out how to disable XDebug … or perhaps just XDEBUG_MODE=coverage is sufficient per https://www.drupal.org/project/drupal/issues/3405976#comment-15348344.

from php.

csandanov avatar csandanov commented on June 3, 2024

Did you try to unset PHP_XDEBUG env var to completely disable xdebug extension? (this is why we introduced this var in addition to the XDEBUG_MODE)

Also, I don't know it it's possible in your pipeline, but you can maybe set different image tags for different PHP versions, like the last tag where we still had PHP 7.4 was 4.33.4 which would be wodby/php:7.4-dev-4.33.4

from php.

wimleers avatar wimleers commented on June 3, 2024

I never set PHP_XDEBUG. I'm not sure I can unset it in GitLab CI, as described at https://stackoverflow.com/a/55204041.

from php.

wimleers avatar wimleers commented on June 3, 2024

… but I did just figure out a way to dynamically set the -4.40.9 suffix for only some PHP versions: https://git.drupalcode.org/project/acquia_migrate/-/merge_requests/14/diffs. 👍

from php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.