Comments (4)
@idoros is there any disadvantage to manual name-spacing? (performance, etc)
i can't think of a reason not to use @namespace
, and this means we should show it in every example we make in order to imply it's a best-practice. (we will also add it to the best-practices guide)
from stylable.
namespace has no performance, target size, and I'm not sure it's best practice, but it will give clarity to the output CSS if we when we show it.
The issue is less about the namespace, and more about writing the output CSS with the actual scoping results.
from stylable.
I started implementing this, and abandoned my changes mid-work. I've reversed my train of thought on this. Adding name-spacing in examples may be less accurate, but it makes them readable without adding unnecessary complexity.
I suggest we go through them one-by-one and decide how we handle them.
For example, when I tried to add namespacing to the example in the pseudo-classes reference guide, the already complex example got too hard to read. And on the other hand, I felt the namespacing didn't add any new information that was relevant to this reference.
Let's go over them 1-by-1 and decide for each one where it makes sense.
from stylable.
@brucelawson can you look at the new examples format in our docs? i'm closing this issue, and if you think it's still not good enough we'll reopen.
from stylable.
Related Issues (20)
- proposal: Type only class definition
- proposal: State declarations HOT 1
- @stylable/jest has no peer dependencies and is broken with jest 28
- proposal: explicit custom-pseudo-element definition HOT 4
- `st-global` utility is not removed from valid @property definitions during transformation
- Imports with side effect HOT 1
- Add runtime validation to the options of our integrations HOT 2
- next.js with disabled JS not working HOT 3
- Unify analyze and transform hooks flow
- Stylesheet does not get applied when using Next.js 13 HOT 1
- Imported custom property false positive analysis
- CSS LSP emits false diagnostics for custom property global syntax
- build stylable without filesystem HOT 4
- question: how to get final css HOT 3
- Cyclic error combines mixin path and var paths
- -st-* declarations on imported class
- proposal: unify selector definition API HOT 1
- stylable build error with storybook 7 HOT 4
- Build errors when running create-stylable-app HOT 1
- Improve runtime injectCSS
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stylable.