Comments (21)
borislit
commented on May 14, 2024
2
@TimCluyts Sure. Ill review and merge right away
from vscode-glean.
borislit
commented on May 14, 2024
1
@capaj Wow ! first of all, thanks for the PR and the issue! Can you please post the snippet you've tried to refactor? Thanks!
from vscode-glean.
eastcoastcoder
commented on May 14, 2024
1
Getting this problem as well. Downgraded to 4.2.2 just to to see if an older version helps. It gives the same error so I think it might either be a problem with a new VSCode update or a conflicting extension.
from vscode-glean.
borislit
commented on May 14, 2024
1
@TimCluyts Ok, I can reproduce! The fix is on its way :)
from vscode-glean.
capaj
commented on May 14, 2024
I actually get this error whenever I focus any code at all. It doesn't even have to be a stateless component. I got it even with a bash script, with html template, with whatever you can think of.
from vscode-glean.
borislit
commented on May 14, 2024
I see. Does it happen when you select a valid component though? If so, can u post a snippet?
from vscode-glean.
petekp
commented on May 14, 2024
Also getting this error with VSCode 1.32.3 during app startup / initial extension activation. Using TypeScript. Glean doesn't appear to load at all, at least the commands aren't available.
[2019-03-29 12:43:36.449] [exthost] [error] [wix.glean] provider FAILED
[2019-03-29 12:43:36.450] [exthost] [error] TypeError: Cannot read property 'superClass' of undefined
at isSupportedComponent (/Users/petepetrash/.vscode/extensions/wix.glean-4.10.1/out/modules/stateful-to-stateless.js:303:28)
at Object.isStatefulComp (/Users/petepetrash/.vscode/extensions/wix.glean-4.10.1/out/modules/stateful-to-stateless.js:310:9)
at CompleteActionProvider.provideCodeActions (/Users/petepetrash/.vscode/extensions/wix.glean-4.10.1/out/extension.js:39:37)
at define.provideCodeActions.a.asPromise (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:564:641)
at t.asPromise.Promise (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:48:58)
at new Promise (<anonymous>)
at Object.t.asPromise (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:48:32)
at I.provideCodeActions (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:564:612)
at define.$provideCodeActions._withAdapter.e (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:580:417)
at $._withAdapter (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:575:502)
at $provideCodeActions (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:580:395)
at h._doInvokeHandler (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:593:118)
at h._invokeHandler (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:592:777)
at h._receiveRequest (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:591:383)
at h._receiveOneMessage (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:590:279)
at define.constructor._protocol.onMessage.e (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:588:565)
at u.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:43:254)
at e (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:39:64)
at u.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:43:254)
at s (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:168:754)
at Socket.define.constructor._socketDataListener.e (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:168:960)
at Socket.emit (events.js:182:13)
at Socket.EventEmitter.emit (domain.js:442:20)
at addChunk (_stream_readable.js:279:12)
at readableAddChunk (_stream_readable.js:264:11)
at Socket.Readable.push (_stream_readable.js:219:10)
at Pipe.onread (net.js:636:20)
[2019-03-29 12:43:36.725] [exthost] [info] ExtensionService#_doActivateExtension vscode.extension-editing {"startup":false,"activationEvent":"onLanguage:typescript"}
[2019-03-29 12:43:36.725] [exthost] [info] ExtensionService#loadCommonJSModule /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/extension-editing/dist/extensionfrom vscode-glean.
borislit
commented on May 14, 2024
Hey @petekp , can you post the snipper u've tried refactoring?
from vscode-glean.
petekp
commented on May 14, 2024
@borislit I'm unable to use the plugin — the commands aren't accessible / don't show up since the plugin doesn't appear to load when my extensions are activated.
from vscode-glean.
borislit
commented on May 14, 2024
@petekp hmmm odd. Can you post the React snipper u've tried to refactor?
from vscode-glean.
TimCluyts
commented on May 14, 2024
Having the same issue here on React memo's
const Rows = memo(({ customer }) => { return <span>some layout stuff</span> }
[renderer1] [error] Cannot read property 'superClass' of undefined: TypeError: Cannot read property 'superClass' of undefined
from vscode-glean.
borislit
commented on May 14, 2024
@TimCluyts You are getting this error when You select the snippet?
from vscode-glean.
TimCluyts
commented on May 14, 2024
@borislit When I put my cursor on memo, but even when I just open the file itself.
Additionally I get following error too:
[2019-04-09 10:25:57.544] [exthost] [error] TypeError: Cannot read property 'selection' of undefined at Object.selectedText (c:\Users\****\.vscode\extensions\wix.glean-4.10.1\out\editor.js:37:30) at CompleteActionProvider.provideCodeActions (c:\Users\****\.vscode\extensions\wix.glean-4.10.1\out\extension.js:17:31) at define.provideCodeActions.a.asPromise (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:587:847) at t.asPromise.Promise (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:49:430) at new Promise (<anonymous>)
This is just on top of the superclass of undefined
from vscode-glean.
borislit
commented on May 14, 2024
🎉 This issue has been resolved in version 4.10.2 🎉
The release is available on GitHub release
Your semantic-release bot 📦🚀
from vscode-glean.
borislit
commented on May 14, 2024
@TimCluyts can you verify the issue is resolved?
Also, full credit for the fix goes to @capaj ! My bad I haven't merged this earlier!
from vscode-glean.
borislit
commented on May 14, 2024
@TimCluyts BTW, What refactoring did you try to perform on the memo component? Perhaps its something we should support
from vscode-glean.
TimCluyts
commented on May 14, 2024
The issue on "superclass" has indeed been resolved. But - if you open the output window (Extension host) - and go to a memo class and put your cursor on "memo" it will still give the following:
For that last question, the thing is that I did not in fact try to refactor. It just ended up in de output window when opening the file or selecting the memo itself.
I only actually stumbled upon this issue because I was fighting with another one of my extensions and then, when enabling only Glean, I noticed these issues.
from vscode-glean.
TimCluyts
commented on May 14, 2024
I just created a fix for the issue described above.
from vscode-glean.
TimCluyts
commented on May 14, 2024
@borislit any chance of merging it? I am having to disable Glean because of these issues.
from vscode-glean.
TimCluyts
commented on May 14, 2024
from vscode-glean.
borislit
commented on May 14, 2024
@TimCluyts Done! Thanks for your contribution!
from vscode-glean.
Related Issues (20)
- Can't find this extension in VS Code HOT 4
- Cannot read property `tsAction` of undefined
- Extreme Latency & High Profile Usage HOT 3
- npm install command not working after cloning repo
- Extract to arrow function by default? HOT 1
- Settings: Extract to jsx file instead of tsx
- React Native error: [BABEL] unknown: Preset /* your preset */ requires a filename to be set when babel is called directly. HOT 1
- Extension issue
- Extension issue
- No props validation for Typescript users?
- Extension issue HOT 1
- useEffect refactoring suggestion is overzealous
- When converting from class to function components, useCallback doesn't convert the parameters
- Publish plugin to openVSX
- Prettier cannot run on save HOT 1
- "You must pass a scope and parentPath unless traversing a Program/File. Instead of that you tried to traverse a Identifier node without passing scope and parentPath." Error when converting class to functional component.
- This experimental syntax requires enabling the parser plugin: 'nullishCoalescingOperator' (6:77) HOT 1
- Using Extract Component to File in Client component in NextJS13 breaks it
- Takes too long to save files HOT 1
- Incorrect type. Expected one of string in setting.json
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vscode-glean.