Giter Club home page Giter Club logo

Comments (5)

ScallyGames avatar ScallyGames commented on July 17, 2024

If I got you right this isn't a client but a server issue. Content security should never be handled on the client, because an attacker could easily bypass that.

=> you should change your server to reply with a 401 error instead of serving the static content, hence causing angular to react to the 401 immediately

from angular-http-auth.

CatchSandeepVaid avatar CatchSandeepVaid commented on July 17, 2024

By static contents, i mean the ones present at client side. Example: Labels etc.
So this isnt a server side issue..

from angular-http-auth.

simison avatar simison commented on July 17, 2024

@CatchSandeepVaid resolve your data needs already at routes to prevent Controller loading before you've got the data: https://github.com/johnpapa/angular-styleguide#route-resolve-promises

And possibly implement user rights separately from backend for the client, but don't rely on it for security, as @Aides359 already said.

from angular-http-auth.

witoldsz avatar witoldsz commented on July 17, 2024

My solution to this issue was to create a custom directive which hides everything behind some "please wait" spinner. This directive was also listening for events with some name, like:

<div hide-until-ready="customer-data">
 .... the entire form
</div>

Now, inside the CustomerDataCtrl, when everything is fetched from server and all possible other promises are finally resolved, I publish the "customer-data" event and the spinner disappears showing everything including data loaded from server.

Simple and worked very well. Also there was no need to tinker with routes. It worked everywhere on the page, not only at route changes.

from angular-http-auth.

Iraecio avatar Iraecio commented on July 17, 2024

.config(['$httpProvider', function ($httpProvider) { $httpProvider.interceptors.push(['$rootScope', '$q', 'httpBuffer', function ($rootScope, $q, httpBuffer) { return { responseError: function (rejection) { var config = rejection.config || {}; if (!config.ignoreAuthModule) { switch (rejection.status) { case 401: var deferred = $q.defer(); var bufferLength = httpBuffer.append(config, deferred); if (bufferLength) $rootScope.$broadcast('event:auth-loginRequired', rejection); return deferred.promise; case 403: $rootScope.$broadcast('event:auth-forbidden', rejection); break; } } // otherwise, default behaviour return $q.reject(rejection); } }; }]); }]);
change in line #62 http-auth-interceptor.js
from
if (bufferLength === 1)
to
if (bufferLength)

so ever response with 401, modal login can opem

@CatchSandeepVaid

from angular-http-auth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.