Giter Club home page Giter Club logo

Comments (6)

matthewp avatar matthewp commented on July 18, 2024

Can you provide a minimal reproduction? Thank you.

from astro.

ssalbdivad avatar ssalbdivad commented on July 18, 2024

@matthewp The issue is very straightforward, just apply some shikiConfig in your astro config and notice it renders in .md but not via the Code component.

I don't know if this is by design or what but there's no ambiguity so creating a minimal repro just feels like a hoop jumping.

If you're genuinely having a problem understanding or reproing the issue I will create one. In the meantime feel free to refer to the astro config I have in the branch I linked and try adding a Code component.

from astro.

matthewp avatar matthewp commented on July 18, 2024

Creating a minimal repro is not about proving the bug exists. I believe that it does. The minimal repro helps with debugging and finding the bug. It saves the developer from needing to create one themselves. Thanks.

from astro.

ssalbdivad avatar ssalbdivad commented on July 18, 2024

Well I'm creating this bug as a courtesy to the project and community as I've already found a way to work around this issue locally.

As a maintainer myself, I don't think it's fair to expect users to do extra legwork just so I can avoid it, which would imply I value my own time above theirs.

Personally, I'd value the work that went into submitting something like this in the first place and would want to ensure my bugs were known and triaged, but if you want to close the issue, that's your prerogative as a maintainer.

from astro.

matthewp avatar matthewp commented on July 18, 2024

Sounds good.

Additionally, after talking with others we have never supported this config being applied outside of Markdown since the config is not serializable at runtime. That's why this config is under markdown and not something like syntaxHighlighting.

from astro.

ssalbdivad avatar ssalbdivad commented on July 18, 2024

@matthewp Yeah that's what I wanted to know more about the expected behavior before creating a repro.

I realize it being in the "markdown" key is a little suspicious, but as far as I could tell that was the only config location for it.

I do think it would be very convenient to have some built-in way to get consistent behavior but if it doesn't sound like a feature worth prioritizing I understand.

from astro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.