Giter Club home page Giter Club logo

Comments (2)

kbu1564 avatar kbu1564 commented on July 19, 2024

http://php.net/manual/en/function.parse-url.php
On seriously malformed URLs, parse_url() may return FALSE.

if $url's parameter of parse_url() is wrong url data, that is return false.
I think it should be work about false of return value like before.

https://github.com/Wisembly/elephant.io/blob/refacto-3.0/src/Engine/AbstractSocketIO.php

/**
 * Parse an url into parts we may expect
 *
 * @return string[] information on the given URL
 */
protected function parseUrl($url)
{
    if (($server = parse_url($url)) === false)
    //  throw new ServerConnectionFailureException; ??
        return ['scheme' => 'http',
                'host'   => 'localhost',
                'path'   => 'socket.io',
                'secured' => false];

    if (!isset($server['port'])) {
        $server['port'] = 'https' === $server['scheme'] ? 443 : 80;
    }

    $server['secured'] = 'https' === $server['scheme'];

    return $server;
}

from elephant.io.

Taluu avatar Taluu commented on July 19, 2024

fixed by #64 ; for the return of the parse_url, I'll be opening a new ticket and fix it, as your comment make sense.

from elephant.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.