Giter Club home page Giter Club logo

Comments (1)

deads avatar deads commented on July 3, 2024

Hi,

Thanks for your bug report. It was a bit of a challenge to maintain both Python 2 and 3 support manually. We discovered issues such as this one you found while we built out the automated test suite. Now that our Travis build system is complete and automated Python 2&3 builds, we don't expect this bug to surface again.

https://travis-ci.org/deads/paratext

Python 2.x's PyString_XXX makes no assumptions about the underlying encoding of the data, while PyUnicode_XXX assumes the data is a sequence of valid codepoints. In Python 2.7, the internal string does not need to be a valid sequence of Unicode codepoints (e.g. u"\uDCFF" works in Python 2, but not 3). In Python 3.x, I believe no Unicode string can be constructed unless it is sequence of valid codepoints. In the case where the data is loaded from a file and no assumption can be made about its encoding, one must be a bit more delicate. For Python 3, PyBytes_XXX can be used for this purpose.

Can you repull from master and verify that you are no longer experiencing this issue? Henceforth, all proposed pull requests will have to pass all tests on both Python 2 and Python 3, unless there is a good reason for allowing a test to fail.

Best,
Damian

from paratext.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.