Comments (1)
Hi,
Thanks for your bug report. It was a bit of a challenge to maintain both Python 2 and 3 support manually. We discovered issues such as this one you found while we built out the automated test suite. Now that our Travis build system is complete and automated Python 2&3 builds, we don't expect this bug to surface again.
https://travis-ci.org/deads/paratext
Python 2.x's PyString_XXX
makes no assumptions about the underlying encoding of the data, while PyUnicode_XXX
assumes the data is a sequence of valid codepoints. In Python 2.7, the internal string does not need to be a valid sequence of Unicode codepoints (e.g. u"\uDCFF"
works in Python 2, but not 3). In Python 3.x, I believe no Unicode string can be constructed unless it is sequence of valid codepoints. In the case where the data is loaded from a file and no assumption can be made about its encoding, one must be a bit more delicate. For Python 3, PyBytes_XXX
can be used for this purpose.
Can you repull from master and verify that you are no longer experiencing this issue? Henceforth, all proposed pull requests will have to pass all tests on both Python 2 and Python 3, unless there is a good reason for allowing a test to fail.
Best,
Damian
from paratext.
Related Issues (20)
- Build fails on Windows 7 with Anaconda HOT 3
- Add support for reading large files in chunks HOT 1
- C++ rowbase stream processing?
- Unexpected content conversion for a hex string data HOT 3
- add support for .gz files HOT 1
- add support for opening multiple files HOT 1
- Paratext <-> Apache Arrow bridge HOT 1
- perf problems HOT 3
- can i access data by row HOT 3
- how to install paratext for python3? HOT 1
- Support for tab-delimited files? HOT 1
- Reading from stdin should use single thread or report an error HOT 1
- Feature request : Add support for conda HOT 1
- Feature request: Add `sep` argument for separator HOT 1
- Import fails on OSX 10.12.5 using Anaconda HOT 8
- C++11 compiler warning with clang on OS X
- Unable to read csv
- how to use it in c or c++?
- Issue with paratext.load_csv_to_pandas() HOT 4
- Tested on AWS Lambda - EFS ?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from paratext.