Giter Club home page Giter Club logo

Comments (4)

Choc13 avatar Choc13 commented on June 13, 2024 1

Hi @muratyuceer. That's a good question, but I believe the behaviour is correct. Consul supports long polling in order for consumers to detect changes. As described in that link, long polling works by sending in a blocking query that waits for either the value to change or PollWaitTime to be exceed, at which point it will return to the client immediately and the client must then determine whether it was a timeout or an actual update.

So you should always see changes reflected immediately (minus any network latency). PollWaitTime instead sets how long the request is allowed to "hang" for on the Consul side before it times out. Setting this low would cause a lot of network requests and re-connections between client and server. The maximum value is 10 minutes as if we left it unbounded Consul would never know when to evict unresponsive clients.

I hope that clears things up. Maybe the parameter would have been better named MaxPollWaitTime.

from winton.extensions.configuration.consul.

Choc13 avatar Choc13 commented on June 13, 2024 1

So the technique it uses is called long polling, here is a description.

TLDR; client (your code running this library) makes a HTTP request and the server keeps that connection alive until either the value changes or the wait time is reached. So if the value never changes it will make a new HTTP request every PollWaitTime seconds otherwise it will make a new HTTP request each time the value is updated.

from winton.extensions.configuration.consul.

muratyuceer avatar muratyuceer commented on June 13, 2024 1

I didn't know about this interesting method, thank you for the information.

from winton.extensions.configuration.consul.

muratyuceer avatar muratyuceer commented on June 13, 2024

Hi @muratyuceer. That's a good question, but I believe the behaviour is correct. Consul supports long polling in order for consumers to detect changes. As described in that link, long polling works by sending in a blocking query that waits for either the value to change or PollWaitTime to be exceed, at which point it will return to the client immediately and the client must then determine whether it was a timeout or an actual update.

So you should always see changes reflected immediately (minus any network latency). PollWaitTime instead sets how long the request is allowed to "hang" for on the Consul side before it times out. Setting this low would cause a lot of network requests and re-connections between client and server. The maximum value is 10 minutes as if we left it unbounded Consul would never know when to evict unresponsive clients.

I hope that clears things up. Maybe the parameter would have been better named MaxPollWaitTime.

Thank you for the response, what I'm really curious about is how changes made in Consul are instantly reflected in the application... does it open a connection like a WebSocket in the background? It's probably not sending http requests every second, is it?

from winton.extensions.configuration.consul.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.