Giter Club home page Giter Club logo

Comments (4)

falkTX avatar falkTX commented on June 2, 2024

Persistent asio connection will be a host/app job, wineasio should not try to do that, it is likely not technically possible anyway.
Since this winamp plugin is open-source, it is likely best to report issue there instead. Or better yet, to try to fix it.

from wineasio.

BlueMax avatar BlueMax commented on June 2, 2024

That behavior is probably correct though (for Windows). I rather thought about a general Wine/WineASIO improvement. But if you say its not advisable let's forget about that.

Then the question is why does it crash after some time? Its very unlikely that this happens on Windows. Its a long-standing plugin. It also happens with the original (unmodded) plugin. All other ASIO plugins i've found do not find the WineASIO driver at all (only ASIO4ALL - but that's useless).

Should i file a Wine bug or can you take a look what's going on? I'm not sure what component is responsible for the bug (and who's in charge for that).

from wineasio.

falkTX avatar falkTX commented on June 2, 2024

Crash could be in JACK too, I do not think this would be a Wine bug (though you are welcome to try different versions of wine to see if it makes any difference)

I mention modifying the plugin because of the start/stop driver behaviour is not something I see will change in wineasio. Usually when a tool does something like this, it is bad coding on the application side.
One notable one is audacity, that using portaudio it stops and starts the driver only when playback or recording is active. And we end up with exactly the same issue as we have here with JACK open/close multiple times.

And if we can change the start/stop behaviour of the asio plugin, it likely fixes this issue too.
So seems best to me to try and tackle this by going into that direction first.

from wineasio.

BlueMax avatar BlueMax commented on June 2, 2024

Crash could be in JACK too

Not sure. The behavior when moving the Winamp node in Carla causing a crash is suspicious indeed. But it seems to be (at least from Jacks view) just a "stress situation" that Jack can handle gracefully. Jack hits many xruns but survives and comes back when it cools down (1-2 seconds).

The Winamp crash due to skipping tracks is Wine only (crash or freeze). Jack seems unaffected without any xruns and still works properly.

I mention modifying the plugin because of the start/stop driver behaviour is not something I see will change in wineasio. Usually when a tool does something like this, it is bad coding on the application side.

I'm not sure how Winamp internals work but output plugins probably need to unregister cleanly on stop by (Winamp API) design. Switching plugins in settings dialog during playback usually doesn't have any effect until stop/play.
The driver start/stop behavior itself (at least for me) is not a problem (can be handled by external auto-connectors). But the crashes are.

One notable one is audacity, that using portaudio it stops and starts the driver only when playback or recording is active. And we end up with exactly the same issue as we have here with JACK open/close multiple times.

I've tested that. It does open/close every time indeed but it doesn't crash no matter how often restarted and the node in Carla can be moved without problems. Not tested with the new Audacity v3 though.

And if we can change the start/stop behaviour of the asio plugin, it likely fixes this issue too.
So seems best to me to try and tackle this by going into that direction first.

That's probably above my head but i could ask the mod coder about the plugin behavior.

Unless you still have some ideas i think there is nothing more about WineASIO then. Feel free to close and thank you so far!
Maybe i bring this up on the Jack bug tracker again to catch some more thoughts.

from wineasio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.