Implementation does not reserve the scrollbar width about body-scroll-lock HOT 14 CLOSED

@FL3NKEY thanks for the recommendation. We want to use the library for a large React app, so abstraction is a minimum requirement. However, this is not possible due to the fixed CSS class names. This means that the library cannot simply be replaced later if problems arise.

I'm on my way to the React Conference in Amsterdam/NL. When I get back I'll take care of the PR.

from body-scroll-lock.

hi @martinkutter

thanks for the code - happy for you to create the PR.

Once you create it, I'll try to have it reviewed quickly.

from body-scroll-lock.

You are welcome.

https://github.com/FL3NKEY/scroll-lock

from body-scroll-lock.

Can't wait for the PR. I need this as well! :)
@martinkutter Any progress?

from body-scroll-lock.

@martinkutter updated, check out 🤗

from body-scroll-lock.

Sorry for the delay. Let me look at the solution from @FL3NKEY next week and I'll get back to you.

from body-scroll-lock.

@martinkutter 👍 let me know how it goes - if you end up not putting a PR through, I'll adapt your suggestion and create a PR for body-scroll-lock.

from body-scroll-lock.

Thanks for your patience 😅. I created a PR. #14
@willmcpo please have a look and if everything fits I would be happy about a suggestion for the docs.

from body-scroll-lock.

@martinkutter what's the problem using my library?

from body-scroll-lock.

@FL3NKEY As I mentioned before, we use this library in a large React application based on plugins. For example, a normal use case is that one component activates the scrolllock, then a second component is mounted, which also activates the scrolllock. If the first component deactivates the scrolllock, it is not considered that it is still needed by the second component. So I decided to continue using this library, which can handle it correctly.

from body-scroll-lock.

@martinkutter oh, i got it, work at that 🤗

from body-scroll-lock.

@martinkutter updated

from body-scroll-lock.

@martinkutter thanks I've reviewed it and no problems with the delay 👍

from body-scroll-lock.

PR #14 pending minor change and then will merge

from body-scroll-lock.