If I disable the body scroll twice, I can't enable the body scroll anymore. about body-scroll-lock HOT 9 CLOSED

It should be fixed in recent commits. Please upgrade package to 2.4.2.

Hope that helps.

from body-scroll-lock.

I seem to be having this problem too... v2.6.1

from body-scroll-lock.

Are you calling disableBodyScroll with the same element twice, or different elements? Or no elements? @allengordon011

from body-scroll-lock.

The same element twice, if I understand your question. I believe it was caused by a re-render on calling setState. I updated the componentDidUpdate so it does not call setState, which fixed the problem.
The funny thing is, I think that code had been working for awhile calling disableBodyScroll twice (and enableBodyScroll twice too).
Thanks for your quick reply @diachedelic

from body-scroll-lock.

Ah @allengordon011 , so was diableBodyScroll was called twice in quick succession?

from body-scroll-lock.

Yes, that's right.

from body-scroll-lock.

It seems that because you are supplying the function disableBodyScroll as a click event handler, so the event object is passed as the targetElement argument. targetElement is not optional (see #55) and must be an HTML element.

from body-scroll-lock.

I'm talking about the original repro at https://codesandbox.io/s/0172yjr8n btw, @allengordon011

Just make sure you supply an HTML element to both disableBodyScroll and enableBodyScroll

from body-scroll-lock.

FYI my code supplies disableBodyScroll and enableBodyScroll a ref created in the class constructor as
this.modalRef = React.createRef();
componentDidUpdate fires disableBodyScroll if (!prevProps.visible && this.props.visible) and enableBodyScroll if (prevProps.visible && !this.props.visible). Seems to be working now.

from body-scroll-lock.