Giter Club home page Giter Club logo

Comments (2)

srijan-paul avatar srijan-paul commented on May 24, 2024 1

So I looked into the source code for CanvasSpace and I think I might have zeroed in on the problem.
requestAnimationFrame here in src/Space.ts but the corresponding call to cancelAnimationFrame does not happen until the last set of players are updated, as can be seen here.

Another problem that may happen is when we call removeAll, we simply set this.players to {}, thereby losing all information about the requestIDs, and they then stay uncanceled.

Or... get this, I'm wrong and it's something else entirely :p

Either way, let me know if you're open to contributions and I'd be happy to take a stab at this!

from pts.

williamngan avatar williamngan commented on May 24, 2024

Thanks for the detailed description. This looks like a bug where the last frame is not stopped after dispose is called. I will look into a fix for this. Thank you!

from pts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.