Giter Club home page Giter Club logo

Comments (3)

WillCodeForCats avatar WillCodeForCats commented on August 22, 2024 1

Yeah that should probably do it. PR #102

from solaredge-modbus-multi.

WillCodeForCats avatar WillCodeForCats commented on August 22, 2024

The warning is generated in the data update class that does not have access to the options data (only the interval is passed to it), so there probably isn't a way to suppress it.

from solaredge-modbus-multi.

spali avatar spali commented on August 22, 2024

just checked the source, looks like it's in this integration:

if scan_interval < 10:
_LOGGER.warning("Polling frequency < 10, requiring keep modbus open.")
self._hub.keep_modbus_open = True

So it looks like it force sets the connection to stay open anyway in this case. But maybe the if could be extended to also check the setting:

        if scan_interval < 10 and not self._hub.keep_modbus_open:
            _LOGGER.warning("Polling frequency < 10, requiring keep modbus open.")
            self._hub.keep_modbus_open = True

assuming self._hub.keep_modbus_open has already the value set from the user config at this time.

from solaredge-modbus-multi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.