Comments (4)
The reason for current position was to put top menu icon line best-possibly on cap height line of “Wikimedia”, not centered to both lines.
If you are providing a patch, we could better evaluate your input.
from wikimediaui-style-guide.
I got that you're aiming to put the icon in line with "Wikimedia" but the system that I am using still shows the menu icon slightly above.
The current position with top 1.2rem
The position I am proposing with top 1.5rem
from wikimediaui-style-guide.
@Nisarg-27 I hope you're aware that the font is dependent on the platform one's browsing on and that letter boxes are hard to come by.
Without a clearly fleshed out and intensely wide tested plan, I don't think it's useful to put effort into this.
from wikimediaui-style-guide.
Closing this as is. Feel free to reopen when provide a patch set tested against our supported browser defined in https://github.com/wikimedia/WikimediaUI-Style-Guide/blob/master/.browserslistrc
from wikimediaui-style-guide.
Related Issues (20)
- Typography - specimen svg image does not display as expected
- SVG image for tpography-readability is missing spaces around links HOT 1
- [Typography] - what is the preferred treatment for system messages/alerts/dialogs? HOT 1
- Move resources to a different folder and use submodules HOT 13
- Move icons into its own repo HOT 4
- Load Resource 404 Error HOT 10
- [CSS] Use partials for modular CSS architecture? HOT 4
- Alerts in Components HOT 7
- Specify "common meaning" for utility colors HOT 4
- Add a link to the design team blog HOT 4
- Buttons look wrong in Firefox HOT 14
- Increasing the width of color blocks HOT 6
- Text flowing off the page HOT 1
- Add more component design guidelines HOT 12
- Add "scroll to top" button in web page HOT 11
- Add "dark mode" button in the website HOT 21
- ADD follow section in footer! HOT 3
- Transform build scripts from Grunt to npm based scripts HOT 9
- Consider dropping Squoosh HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wikimediaui-style-guide.