Filters breaking in december!! about wikicontrib HOT 23 CLOSED

Hi, I'm from Outreachy. I'd like to work on this issue.

from wikicontrib.

@srish Done ma'am! #153

from wikicontrib.

@Je-Ni hi and welcome! if you have any questions feel free to reach out in the chat: https://wikimedia.zulipchat.com/#narrow/stream/220258-gsoc20-outreachy20/topic/WikiContrib

from wikicontrib.

Hi, going through issue #98 and the PR sent for #99, it seems this issue has been resolved and awaiting PR merge. Please confirm.

from wikicontrib.

@Je-Ni Thanks for bringing this up. Indeed, there is a PR awaiting merge. I can't remember if there were any reasons behind not merging it. There are two options:

• You could test that PR and push any necessary changes to it.
• I can merge that PR, and then you test this issue and create a new PR if necessary.

Which approach would you like to take?

from wikicontrib.

Hi @srish, the backend is taking a bit of time to set up in my system as I don't have a python set up already. So I would prefer to go with option 2.

from wikicontrib.

@Je-Ni I just realized that option 2 won't work as the PR creator deleted the repository a while ago :-/

from wikicontrib.

@srish Hello kindly assign me to this task I can fix it!

from wikicontrib.

@Je-Ni Are you still interested in working on this task? If not, I will consider assigning it to @gotham3.

from wikicontrib.

Hi @srish, please reassign it to @gotham3. I've been having python interpreter not found errors in my windows 10.

from wikicontrib.

Hey @srish , I am Outrachy applicant and i would like to work on this issue. Can you please assign this to me? Thanks
PS: i have already setup the repo.

from wikicontrib.

Hi @srish Could I take up this issue?

from wikicontrib.

Hi @srish
Kindly review my PR
#145

from wikicontrib.

Thanks a lot @gotham3 for your work on this! :)

from wikicontrib.

@gotham3 This PR was causing an error, so I had to revert it. Here is the error:

./src/result.js
Syntax error: Identifier 'st' has already been declared (75:9)

  73 |   render = () => {
  74 |     let { start_time: st, end_time: et } = this.props.filters;
> 75 |     let st = new Date(st),
     |         ^
  76 |     st_m = st.getUTCMonth(),
  77 |     et = new Date(et),
  78 |     et_m = et.getUTCMonth();

Would it be possible for you to send a new PR with updated changes?

from wikicontrib.

@gotham3 I tried your PR but it showed wrong range in some cases like the one shown below. The range here should be December 2018 but it shows December 2019.

from wikicontrib.

@srish I try to correct that case #157

from wikicontrib.

@gotham3 thank you for your changes! @harshika18 let's chat in issue 157.

from wikicontrib.

This is the one of the major issues the app was facing in december. I will just enquire correctly if this is fixed. Outreachy students, please don't submit any more PR. I also need to check if #172 is correct PR for it. AFAIR the impact of this bug has to be large on code. Let me test it. I will get back to you on this PR by this weekend (mostly).

from wikicontrib.

@rammanoj @srish , PR #177 along with fixing the issue of filters jumping one Month ahead #123 , also fixes this issue.

from wikicontrib.

@srish can this be assigned to me?

from wikicontrib.

@NdibeRaymond See #102 (comment).

from wikicontrib.

@srish , the PR I submitted that potentially fixed this bug #117 was submitted on 28th last month, it hasn't been tested, and #172 doesn't seem to fix it

from wikicontrib.