Giter Club home page Giter Club logo

Comments (7)

robdodson avatar robdodson commented on September 16, 2024

It's skipped over by TalkBack on Android. I'll check the example on my iPhone when I get into the office tomorrow. Because the <p> has aria-hidden and the underlying <a> has tabindex=-1 it should be skipped over. If it's not being skipped over on iOS there may be an error in the polyfill on the current version of mobile safari

from inert.

alice avatar alice commented on September 16, 2024

Thanks for looking into this, @simevidas!

I just had a play, and I get the same results you do. I also tried setting aria-hidden explicitly immediately after inert was set and that does cause it to be correctly skipped by VoiceOver.

Hmmmmm.

from inert.

robdodson avatar robdodson commented on September 16, 2024

Looks like setting the inert property isn't triggering anything. Setting it to true should poke the polyfill to set aria-hidden=true on the p

screen shot 2016-08-07 at 6 57 35 pm

from inert.

robdodson avatar robdodson commented on September 16, 2024

Issue might be just that we need to transpile the classes down to ES5
https://github.com/WICG/inert/blob/master/inert.js#L48

:P

from inert.

alice avatar alice commented on September 16, 2024

Yep that looks like it.

from inert.

robdodson avatar robdodson commented on September 16, 2024

Transpiled version may work https://output.jsbin.com/dageru
Gotta double check on a real phone tomorrow. My iOS simulator is outdated

from inert.

simevidas avatar simevidas commented on September 16, 2024

Works 👍

from inert.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.