Giter Club home page Giter Club logo

Comments (6)

stonebig avatar stonebig commented on June 18, 2024

hum,

on my own method using the generic check digits algorithm given per GS/1, I get the same result as python-barcode:

image

so maybe this shall be "rebranded" as "ean_key_computation", but it's not faulty as you think

from python-barcode.

WhyNotHugo avatar WhyNotHugo commented on June 18, 2024

The issue is that the implementation saves the whole number plus the checksum into self.ean, but then calculate_checksum calculates the checksum for self.ean (e.g.: a string which already includes the checksum).

from python-barcode.

WhyNotHugo avatar WhyNotHugo commented on June 18, 2024

While this is the "expected behaviour" as per the documentation, it's obviously un-intuitive and can be improved. I'm just not sure how to improve it without breaking existing usages.

from python-barcode.

WhyNotHugo avatar WhyNotHugo commented on June 18, 2024

I think that #215 should fix it. Can you confirm?

from python-barcode.

WhyNotHugo avatar WhyNotHugo commented on June 18, 2024

Fixed in #213

from python-barcode.

WhyNotHugo avatar WhyNotHugo commented on June 18, 2024

f242961 fixes EAN14

from python-barcode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.