Comments (11)
A better way to see which node version is in which Electron version:
https://github.com/electron/releases
Looking at how the v3.0.0 was released, once they are done with beta versions, they have a few nightly versions and then release it for good. Feels like we'll get v4.0.0 around New Year's 🎄
from video-hub-app.
When working on this, should be easy to close this issue too: #24 👍
from video-hub-app.
I just tried beta 11 there on master and it works! 🎉
from video-hub-app.
Electron v4.0 is out as of 1 hour ago 🎉
https://github.com/electron/electron/releases/tag/v4.0.0
We'll upgrade in a few days 👍 -- or feel free to open up this change as a PR with the version bump 💯
from video-hub-app.
A wild PR has appeared! 🍃 #33
from video-hub-app.
Thank you!
I'm happy to update to node v10 and to this new approach -- will do so along with my angular7 branch 👍
ps -- some users have requested we ignore files that start with .
and with _
which we'll do as well 👌
from video-hub-app.
master has been updated with node 10.14 so this is ready for a PR -- whenever you'd like 🥇
from video-hub-app.
Darn, looks like electron 3.0.10 only has node v10.2.0 - https://electronjs.org
Unless I'm wrong, this will have to wait until electron 4?
from video-hub-app.
I think you're right - https://electronjs.org/releases#3.0.0 electron 3 comes with Node v10.2.0
I suspect electron 4 is coming out soon - before we have our next release 👌
from video-hub-app.
Nice! 🎉
I noticed you tried to use v4 in your original upgrade - was there any problems, and would it be possible to have a beta branch to test it out?
from video-hub-app.
It's worth a try -- feel free to give it a go: electron 4 beta 10 came out 30 minutes ago:
https://github.com/electron/electron/releases/tag/v4.0.0-beta.10
I tried it before but something wasn't working (could have been something else), so I just rolled back to decrease the number of moving pieces, fixed the problem, and never tried with the version 4 beta 🐟
edit: tried the beta 10 and the app wouldn't compile:
internal/validators.js:125
throw new ERR_INVALID_ARG_TYPE(name, 'string', value);
^
TypeError [ERR_INVALID_ARG_TYPE]: The "file" argument must be of type string. Received type object
at validateString (internal/validators.js:125:11)
I'm happy to just wait for the non-beta release 👌
from video-hub-app.
Related Issues (20)
- Right column in gallery empty after close HOT 1
- Consider reducing space between search inputs
- Reset progress better
- Name Tagging HOT 1
- Build a playlist functionality
- Server problem HOT 3
- Fix incorrect column count when app zoom level set HOT 2
- Hide the 5 bottom-tray tab buttons from ribbon HOT 7
- Add optional password to hub HOT 3
- Gallery meta redesign ideas
- "Rescan" button can be right-clicked but nothing happens HOT 2
- Favorites-only view
- Add settings option to increase timeouts during ffmpeg extractions
- Add option for video location to act as a folder
- File Management Options Grayed Out With Duplicate Search HOT 1
- Kiosk mode (via shortcut key) - improve behavior
- make "Add tag" text less contrasty
- Bug: in "recent" in bottom tray during compact view
- bug: last played sort order janky
- Rewrite BehaviorSubjects as signals
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from video-hub-app.