Comments (14)
Looking through whatwg.org.conf looking for other "squashing" redirects I don't see anything else that looks suspicious, so I think we're good here.
from whatwg.org.
Thanks. I'm guessing this must have regressed as part of the move to Nginx. https://github.com/whatwg/misc-server/blob/master/debian/marquee/nginx/sites/whatwg.org.conf#L124 doesn't seem to account for multipage/ links.
from whatwg.org.
The original Apache setup is in 928a87b.
I was quite conservative in the conversion and AFAICT this ought to not have worked before either. Hard to say with confidence without erecting the Apache server again though.
Anyway, I can make them work.
from whatwg.org.
In particular redirect 301 /specs/web-apps/current-work/ https://html.spec.whatwg.org/
suggests to me that https://whatwg.org/specs/web-apps/current-work/x
would go to https://html.spec.whatwg.org/x
. Currently that just redirects to https://html.spec.whatwg.org/
.
from whatwg.org.
Nginx seems to do some kind of catch-all approach rather than forwarding the original subpath+query.
from whatwg.org.
Aha, you're right, that "multipage" didn't appear in the destination URL doesn't mean it didn't work.
from whatwg.org.
We should probably also vet the other redirects just in case we turned more into catch-all where we simply wanted to forward the original subpath+query (no idea what the term for this would be).
from whatwg.org.
I'm pretty sure the problem here is at "fall back to single-page HTML". Any return 30x line that doesn't have a $1
or $2` in it is redirecting everything to a fixed URL. I had to make some judgements about things like that, but this one was a mistake and not deliberate.
from whatwg.org.
Okay, I guess we do have plenty of redirect tests already so we just need to add some for this.
from whatwg.org.
OK, so what I didn't realize was that the original "redirect 301 /specs/web-apps/current-work/ https://html.spec.whatwg.org/" was intending to preserver a trailing /multipage/. An easy fix coming up.
from whatwg.org.
http://www.whatwg.org/specs/web-apps/current-work/multipage/links.html#other-link-types works with whatwg/misc-server#63
from whatwg.org.
Thanks @tantek!
from whatwg.org.
(Note that you might have to clear cache to get this to work.)
from whatwg.org.
Works great. Thanks for the quick fix @foolip @annevk !
from whatwg.org.
Related Issues (20)
- Make headers sticky? HOT 4
- Update FAQ for AppCache removal HOT 1
- Review Drafts issue HOT 6
- List Twitter accounts on spec.whatwg.org
- deploy.sh (build resources) fails with unbound variable error
- Make deploy (and make remote) fail when EXTRA_FILES exist HOT 8
- convert_sg_db.py should alphabetize by standard name
- broken link to multipage HOT 1
- review.sh: make it easier to overwrite a copy
- Tweak color contrast of highlighting
- Consolidate colors
- SW fails to fetch spec CSS on first load of the day HOT 2
- Confusing UI for `<details>` in the Participant Agreement HOT 6
- Sort out hgroup usage HOT 3
- New checker for https://whatwg.org/validator/
- Store specification build outputs in git HOT 3
- Definitions in headings are visually unrecognizable HOT 7
- Restore the "new issue" feature
- Broken link from working mode to Stages.md HOT 2
- Host the NodeJS icon? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from whatwg.org.