Configure full-screen slide out for hamburger menu about wevotecordova HOT 10 CLOSED

Still have some menu loop bugs to resolve, but the menu is done (but not checked in)

from wevotecordova.

Very cool! I have been doing some parallel menu work that I will check in shortly.

from wevotecordova.

@DaleMcGrew Does your work replace this work? Should I put this work aside?

from wevotecordova.

@SailingSteve No it does not. I'm happy to discuss on the hangout, which I'm opening shortly.

from wevotecordova.

@DaleMcGrew
This menu is based on react-slide-out that has a problem in our app, of sliding out too fast, maybe in a 1/10th of a second instead of a half. I swapped react-slide-out for react-sliding-pane which had the same problem.

I looked at mango/slideout which claims Cordova compatibility. This has a $18 per product license fee (I would have paid it in a second), but it hasn't had a core code fix in a year and has 33 open issues, and 13 open pull requests.

So for now, I'd like to go with imperfect sliding until we have time to work on this more.

from wevotecordova.

@SailingSteve, I support your decision! Would it be possible for you to test the package you are choosing on WebApp, to see if the slide-out timing works in the direct WebApp bundle (on the website)? BTW, I've been looking at optimizations, and I think some of the slow-down comes from the 52 (!) API calls we make for the ballot to load. I think we can cut this in 1/2, which will decrease the work we are asking our browser clients to do.

from wevotecordova.

@DaleMcGrew This is what it will look like with one of our home made modals (Just a conditional opaque div on top of everything else)

from wevotecordova.

Looks great @SailingSteve!

from wevotecordova.

react-tostify, that we use, relies on https://reactcommunity.org/react-transition-group/ that should do the job when we want to dig in again.

from wevotecordova.

Closing until we decide to open up the menu animations again.

from wevotecordova.