Comments (10)
Still have some menu loop bugs to resolve, but the menu is done (but not checked in)
from wevotecordova.
Very cool! I have been doing some parallel menu work that I will check in shortly.
from wevotecordova.
@DaleMcGrew Does your work replace this work? Should I put this work aside?
from wevotecordova.
@SailingSteve No it does not. I'm happy to discuss on the hangout, which I'm opening shortly.
from wevotecordova.
@DaleMcGrew
This menu is based on react-slide-out that has a problem in our app, of sliding out too fast, maybe in a 1/10th of a second instead of a half. I swapped react-slide-out for react-sliding-pane which had the same problem.
I looked at mango/slideout which claims Cordova compatibility. This has a $18 per product license fee (I would have paid it in a second), but it hasn't had a core code fix in a year and has 33 open issues, and 13 open pull requests.
So for now, I'd like to go with imperfect sliding until we have time to work on this more.
from wevotecordova.
@SailingSteve, I support your decision! Would it be possible for you to test the package you are choosing on WebApp, to see if the slide-out timing works in the direct WebApp bundle (on the website)? BTW, I've been looking at optimizations, and I think some of the slow-down comes from the 52 (!) API calls we make for the ballot to load. I think we can cut this in 1/2, which will decrease the work we are asking our browser clients to do.
from wevotecordova.
@DaleMcGrew This is what it will look like with one of our home made modals (Just a conditional opaque div on top of everything else)
from wevotecordova.
Looks great @SailingSteve!
from wevotecordova.
react-tostify, that we use, relies on https://reactcommunity.org/react-transition-group/ that should do the job when we want to dig in again.
from wevotecordova.
Closing until we decide to open up the menu animations again.
from wevotecordova.
Related Issues (20)
- Should be responsive to the keyboard Go key in iOS
- Returning to app: Landing page should be /ready HOT 2
- Need to stop using UIWebView in Cordova iOS before December 2020 HOT 1
- Ready Page > Find Candidates: Form blocked by Keyboard
- "Following" and "Followers" takes you to "Page not found"
- Share modal obscures Sign in modal
- Week of Sept 1, 2020 work toward a new pt release HOT 3
- Apple Silicon ARM64 Development HOT 3
- Requesting App Rating popup in iOS/Android Apps
- Need the ability to remove account from iOS app, for submissions after June 30, 2022
- Slick-Slider layout problems on iPhone XR & XS Max, Send this ballot to yourself HOT 2
- Update vip.html file to remove reference to button graphic that is gone HOT 1
- App crash in ios simulator when keyboard appears for AddressBox if ENABLE_FACEBOOK is true HOT 1
- New ugly message from facebook/apple on iOS -- need to avoid it HOT 2
- Header styles: Upon sign out, Sign In page scrolled above header HOT 1
- Header styles: After Twitter sign in, notification box partially hidden under header
- Header Styles: Mobile settings page "Our Promise" text at top of screen
- Header Styles: Toast message should not render to very top of screen HOT 1
- Header Styles: Following Facebook sign in, page displays under header HOT 3
- Push Notifications Entitlement Needed HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wevotecordova.