Old Screen Cleaning about wescan HOT 12 CLOSED

Hey, you need to make sure you're creating a new ImageScannerController() every time, so you don't accidentally present the old one (which still has the old image). Let me know if you have any troubles after doing this 🙂

from wescan.

That's true - I'm in favor of having a reset function.

from wescan.

If this is agreed on I can make a quick PR (shouldn't be too hard) to add a reset method when I have some time 🙂

from wescan.

Upon further thought, I think we should implement a method to reset the ImageScannerController to it's original state (I'm thinking of a use case where the controller is displayed in an always-available pull up state from the bottom of the screen). Thoughts?

from wescan.

It can be. I solved my problem your first advice.

from wescan.

Yes, but I think it would still be useful to have a method to reset the controller.

from wescan.

Since it's aUINavigationController, can't implementors simply pop the view controllers until the one they want @justjs?

from wescan.

While I haven't checked, wouldn't that possibly leave the previously detected rectangle on the scanner screen? Even if it does work I feel like it would be only a workaround, and could easily break if, for example, we add a new screen in the future.

from wescan.

Sounds like a plan! Thanks again for your contributions!

from wescan.

Good day! I end up with the same problem to reset the controller to get various images, so i added this code but i do not think it's the best solution.

In the "ImageScannerController" set this new function
public func reset(){ let scanner = ScannerViewController() self.setViewControllers([scanner], animated: false) navigationBar.tintColor = .black navigationBar.isTranslucent = false self.view.addSubview(blackFlashView) setupConstraints() }

And in the didFinishScanningWithResults call the reset function

scanner.reset()

Could you tell me if there is a better solution?

from wescan.

I'd be happy to create a PR for this if there is still interest in this. Please let me know and I'll go ahead and work on it @julianschiavo @Boris-Em

from wescan.

This issue is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.

from wescan.