Comments (3)
Looks like it'll be fine. The tests and other minor cleanups are pretty extensive, but not complicated. I'll finish that up soon.
from jmisb.
Problem is what to do about things like UasDatalinkString that are re-used between tags? If every tag had its own type this would be straightforward, but I'm not sure that feels right.
from jmisb.
The rough plan is an (optional?) constructor argument that initialises in a new private final String
field - it'll be easy to fill in at the Factory level, and generally OK elsewhere - you probably know what the String is for when you're making it.
Thoughts on optional?
I liked the idea of different types for different tags because it makes it easier to debug when its a List, and its not much effort to implement because you just subclass and the IDE fills in the constructors - really more test and documentation.
However this is probably enough for UasDatalinkString usages.
from jmisb.
Related Issues (20)
- Upgrade jqf (fuzzer) plugin. HOT 1
- ST 0903 BitMaskSeries does not check array bounds correctly
- Implement Time Transfer Local Set and Pack (ST 1603)
- Upgrade log4j to 2.17.1 or later
- Duplicate package files causing build to fail in Android Studio HOT 8
- Embed KLV in H264 stream HOT 3
- ST 1602 follow-up tasks (2.x)
- ST 0602 may not decode last item in Universal Set
- api-ffmpeg integration tests are flaky HOT 3
- Support MIMD generation of more than one version HOT 1
- Upgrade spotbugs to 4.7.0 (or later) HOT 1
- onVideoReceived and onMetadataReceived not synchronized HOT 6
- Need more digits of precision in displayableValue HOT 4
- Synchronization errors (lag) between video and metadata HOT 10
- Question - Java 19 Support HOT 2
- NullPointerException in PlaybackControlPanel class HOT 4
- Support processing InputStream in KlvParser
- Bump ffmpeg-platform so build succeeds on ARM macOS machines HOT 2
- Bump ffmpeg on 2.x branch HOT 1
- Parameters swapped HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jmisb.