Comments (9)
Yes, but I'm really thinking to drop all environment variables. Marking them as deprecated for now as I see little reason to use them over using the command-line. The only advantage I see it the ability to use Kubernetes secrets directly without setting up a shell script.
Why do you prefer environment variables?
from docker-ngrok.
If I'm on my desktop, running tests, in development, I HATE environment variables, everything needs to be on the command line so I can see what broke. However, when doing any deployments, environment variables are so much more preferred.
In deployments, every machine runs the same docker image, with the same command line and all variables are changed with the environment. When I run a new image on a box, all I have to do is name the image, and point to the customized environment file. Done. Easy button.
Every server gets the following, no customized command lines, easy deployment.
# docker run --env-file ~/ngrok.env wernight/ngrok
I strongly encourage keeping the environment variables, if for no other reason than to provide someone a choice. You can make the primary entry into the application command line, but please keep the option of environment variables.
Now, this image is hardly deployed, but the fact it is set up for those advanced features (environment variables, exposed ports), makes you ahead of the game and a good example of a custom package.
from docker-ngrok.
No worries I'm not planning to remove them soon, just want to avoid people relying on them first and understand to strong needs.
Have you looked into using docker-compose.yml
to perform the same thing? I have such a file on almost all my projects for development. You can also use environment variable in it.
from docker-ngrok.
I do use it, when appropriate, and I'm not against it.
My OCD is against having:
- NGROK_AUTH
- NGROK_SUBDOMAIN
- NGROK_PROTOCOL
- NGROK_DOMAIN
- NGROK_USERNAME
- NGROK_PASSWORD
- HTTP_PORT
https://youtu.be/ueZ6tvqhk8U?t=19s
from docker-ngrok.
Ha ha. Fair point.
from docker-ngrok.
I too strongly recommend against removing environment variable support. One of the great things about running docker is you can encapsulate all configuration in an environment file, which I have always used when running ngrok in docker.
from docker-ngrok.
Ok
from docker-ngrok.
Updated README and note that NGROK_PORT
is supported.
from docker-ngrok.
Thank you kindly. I shall name a Pokémon after you.
from docker-ngrok.
Related Issues (20)
- Periodically rebuild image HOT 3
- api/tunnels returns empty response when using auth HOT 1
- Does not support spaces in password
- I need help to expose NextCloudPi
- Add NGROK_LOOK_DOMAIN commit to dockerhub HOT 1
- Updating NGROK docker and other questions HOT 1
- Receive ngrok url HOT 4
- Request: image version tag
- authtoken is not respecting in container HOT 1
- Nginx is showing always after generating ngrok url
- Cannot link to webcontainer
- Update? HOT 1
- Inspect Option Support? HOT 1
- multiple ports HOT 1
- transfer maintainership to ngrok? HOT 3
- Add ARM64 (Apple Silicon) support HOT 2
- NGROK_AUTH not working HOT 4
- Add ARM64 (Apple Silicon) support HOT 1
- Ngrok
- ERROR: unknown shorthand flag: 'o' in -ostname=my-app.ngrok.io HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docker-ngrok.