Giter Club home page Giter Club logo

Comments (22)

ToxMox avatar ToxMox commented on May 28, 2024 1

I think it was because of the underscore in librnnoise_vst.dylib I renamed again to librnnoise.vst.dylib and that works. Renamed back to the original name to make sure I didn't screw anything up and it isn't seen again.

from noise-suppression-for-voice.

werman avatar werman commented on May 28, 2024 1

That's not even better. Ok, Then I'll just add that name of the lib may matter, without knowing why it doesn't work like this there is no point in changing default name.

Thanks for the investigation!

from noise-suppression-for-voice.

kuyazee avatar kuyazee commented on May 28, 2024 1

@AGulev try #136 we discuss the vst issue there

from noise-suppression-for-voice.

werman avatar werman commented on May 28, 2024

For mac build should not differ from other platforms, so you'd need CMake (https://cmake.org/download/) and you can build everything with:

cmake -Bbuild-x64 -H. -DCMAKE_BUILD_TYPE=Release
cd build-x64
make

in repository directory.

If any issues arise - ask, they probably will...

from noise-suppression-for-voice.

ToxMox avatar ToxMox commented on May 28, 2024

On the 3rd step of make I get the following:

Mac-mini:build-x64 toxmox$ make
[ 20%] Linking CXX shared library /vst/librnnoise_vst.dylib
clang: warning: argument unused during compilation: '-static-libstdc++' [-Wunused-command-line-argument]
ld: library not found for -lRnNoisePluginCommon
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [/vst/librnnoise_vst.dylib] Error 1
make[1]: *** [CMakeFiles/rnnoise_vst.dir/all] Error 2
make: *** [all] Error 2

from noise-suppression-for-voice.

ToxMox avatar ToxMox commented on May 28, 2024

Side note. I was originally getting this error and edited out -static-libgcc and ran again and got the message above.
Mac-mini:build-x64 toxmox$ make
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/toxmox/werman/noise-suppression-for-voice/src/vst_plugin/build-x64
[ 20%] Linking CXX shared library /vst/librnnoise_vst.dylib
clang: error: unsupported option '-static-libgcc'
make[2]: *** [/vst/librnnoise_vst.dylib] Error 1
make[1]: *** [CMakeFiles/rnnoise_vst.dir/all] Error 2
make: *** [all] Error 2

from noise-suppression-for-voice.

werman avatar werman commented on May 28, 2024

Side note. I was originally getting this error and edited out -static-libgcc and ran again and got the message above.

I think it's indeed not needed on Linux or Mac.

ld: library not found for -lRnNoisePluginCommon

That's interesting, what do you have in build-x64/lib/ ?

from noise-suppression-for-voice.

ToxMox avatar ToxMox commented on May 28, 2024

Ok I screwed up the first time so I started over. Copied over the VST 2 SDK files. Edited all the static lib stuff out of everything then ran the commands and everything built. Now the problem I have is the plugin isn't detected by Reaper. I copied the librnnoise_vst.dylib from the build-x64/bin/vst folder into the folder where VST 2 files go then rescanned the plugins in Reaper and it didn't show up. Thoughts?

from noise-suppression-for-voice.

ToxMox avatar ToxMox commented on May 28, 2024

On a whim I renamed it to librnnoise.vst and it worked. Hooray! Thanks for your help :)

from noise-suppression-for-voice.

werman avatar werman commented on May 28, 2024

Hmm, interesting, thanks.

But why .vst... It's a shared library, maybe it's a whim of that application.

from noise-suppression-for-voice.

werman avatar werman commented on May 28, 2024

I'll update documentation later and remove static linking of libgcc

from noise-suppression-for-voice.

ToxMox avatar ToxMox commented on May 28, 2024

Just to add to this. The plugin is only working in Reaper on the Mac. All other apps that support VSTs don't seem to detect or work with it. I think it has something to do with it being a dylib instead of bundled into a VST or something. Kind of above my pay grade.

from noise-suppression-for-voice.

werman avatar werman commented on May 28, 2024

Huh, and here I thought it would just work™...

And I think I found what to do with it - overdrivenpotato/rust-vst2#6

from noise-suppression-for-voice.

ToxMox avatar ToxMox commented on May 28, 2024

Thanks! I did the Xcode instructions and that worked.

from noise-suppression-for-voice.

werman avatar werman commented on May 28, 2024

That's great! So you created the right folder structure, Info.plist, removed *.dylib extension and it worked?

from noise-suppression-for-voice.

ToxMox avatar ToxMox commented on May 28, 2024

In Xcode I used the bundle template then I created the structure using Xcode. I then copied the plist example over from that thread. And yes I did remove the .dylib extension.

I first tried that shell script someone posted there but that didn't seem to work. I can try that again later and report back.

This bundling of the dylib also explains the issue above about having to rename the file then Reaper saw it. Turns out Reaper just doesn't care about the bundle stuff I guess. Now that it is properly bundled I'm assuming it works now in all the apps.

from noise-suppression-for-voice.

werman avatar werman commented on May 28, 2024

Could you post the working end result you have?

from noise-suppression-for-voice.

ToxMox avatar ToxMox commented on May 28, 2024

rnnoise.vst.zip
Let me know if this is what you are looking for.

from noise-suppression-for-voice.

werman avatar werman commented on May 28, 2024

Yes, thanks.

from noise-suppression-for-voice.

richtong avatar richtong commented on May 28, 2024

On macOS Monterey 12.1 on an M1 Mac MacBook, I downloaded it and stuck it into ~/Library/Audio/Plug-Ins/VST but the rnnoise.vst is not recognized by OBS.

from noise-suppression-for-voice.

kuyazee avatar kuyazee commented on May 28, 2024

@richtong did you get it to work? Also tried on my M1 MBP on BigSur and can't seem to make it work

from noise-suppression-for-voice.

AGulev avatar AGulev commented on May 28, 2024

I tp to show plugin interface and see nothing : macOS Monterey M1 Max

from noise-suppression-for-voice.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.