Comments (5)
Forgot to attach the file ;)
Original comment by [email protected]
on 30 Oct 2008 at 11:09
Attachments:
from googletest.
I just see that I forgot to adjust the WINCE code path.
There should be a
const char expected_text[] = "";
added afterline 13.
Also the name error_text should be changed to actual_text for consistency.
Original comment by [email protected]
on 30 Oct 2008 at 11:11
from googletest.
Thanks for contributing, Phil!
Please take a look at the contributor's guide:
http://code.google.com/p/googletest/wiki/GoogleTestDevGuide
In particular, note that:
- we use http://codereview.appspot.com/ for reviewing patches, and
- you need to sign a CLA in order for us to be able to accept your patch.
We should discuss this on the mailing list first. I'll start a thread there.
Thanks.
Original comment by [email protected]
on 31 Oct 2008 at 6:30
- Added labels: Priority-Low, Type-Enhancement
- Removed labels: Priority-Medium, Type-Defect
from googletest.
Closed as won't fix, as this macro doesn't add much value (there are
alternative ways
to achieve the same effect without introducing a macro).
Original comment by [email protected]
on 5 Nov 2008 at 9:12
- Changed state: WontFix
from googletest.
Sure there are alternative ways, like EXPECT_EQUAL() but it will not nicely
convert
the unreadable COM HRESULT into plain text. I am using the new macros in my
tests,
and maybe someone else finds them useful, even when they are not part of the
standard
googletest distribution.
Original comment by [email protected]
on 6 Nov 2008 at 9:42
from googletest.
Related Issues (20)
- {ASSERT|EXPECT}_[NOT_]NULL(expr) HOT 2
- Need a polymorphic NULL pointer that can be used in function templates HOT 1
- Need to unify the way the GTEST_* macros are interpreted HOT 1
- 'make check' fails with undefined references. HOT 3
- --gtest_repeat should case failures to show up at the bottom
- Failed tests HOT 3
- --gtest_output flag doesn't produce output on platforms where argv[0] is empty HOT 3
- Include StackWalker for windows exception handling HOT 4
- ValuesIn(container<T>) needs to be convertible to ParamGenerator<T1> if T is assignable to T1. HOT 1
- make check fails on ubuntu 8.01 HOT 3
- Support for custom ResultPrinter HOT 8
- Enhance the Macros to enable the user to Specify Comments for TestCase and Test. HOT 3
- Support Multiple Levels of TestCase Specification HOT 1
- the XML report may contain invalid charactor HOT 3
- no way to delete UnitTest instance HOT 6
- need to update the wiki with parameterized test docs HOT 1
- We need well defined test procedure and test runner scripts to test Google Test HOT 1
- Value-parameterized tests must warn about interspersing test definitions and test case instantiations for the same test case. HOT 2
- 'make check' fails on SunOS 5.10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from googletest.