Giter Club home page Giter Club logo

Comments (9)

wellyshen avatar wellyshen commented on July 26, 2024 1

@stramel Thank you for reporting this issue, I know the root cause, will fix it soon!

from react-cool-inview.

stramel avatar stramel commented on July 26, 2024 1

Thank you for reporting this issue, I know the root cause, will fix it soon!

Thanks! Just wanted to confirm that it is still an issue with v1.3.0 https://codesandbox.io/s/react-cool-inviewissues495-with-v130-zosed

from react-cool-inview.

stramel avatar stramel commented on July 26, 2024 1

@wellyshen It does appear that it works properly in a CRA environment. So this probably isn't a bug with the library but maybe one with the browser's Intersection Observer implementation.

I did notice, that it looks like the state isn't reset properly?

image

The inView says true after the observe is called and the new ref has been set. As well as, the scrollDirection is resetting to 'up' even though I never scrolled up.

https://github.com/stramel/react-cool-inview-issue-495

from react-cool-inview.

wellyshen avatar wellyshen commented on July 26, 2024 1

@stramel That make sense, I will fix the scrollDirection part soon.

from react-cool-inview.

stramel avatar stramel commented on July 26, 2024 1

Going to close this issue in favor of a new one to show the other issues that I have found with scrollDirection and inView.

from react-cool-inview.

wellyshen avatar wellyshen commented on July 26, 2024 1

@stramel Thank you bro, your issues really helpful.

from react-cool-inview.

wellyshen avatar wellyshen commented on July 26, 2024

@stramel I copied your example to debug this issue with the latest version in my project (created by CRA) but I can not reproduce it, I'm not sure whether it only exists in the environment of the codesandbox (due to the issue of iframe) or not. Can it be reproduced in your project side?

from react-cool-inview.

wellyshen avatar wellyshen commented on July 26, 2024

@stramel The scrollDirection should be reset in v2.0.1.

from react-cool-inview.

stramel avatar stramel commented on July 26, 2024

Thanks for the cool ๐Ÿ˜Ž library! ๐Ÿ‘๐Ÿผ

from react-cool-inview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.