Comments (9)
@stramel Thank you for reporting this issue, I know the root cause, will fix it soon!
from react-cool-inview.
Thank you for reporting this issue, I know the root cause, will fix it soon!
Thanks! Just wanted to confirm that it is still an issue with v1.3.0 https://codesandbox.io/s/react-cool-inviewissues495-with-v130-zosed
from react-cool-inview.
@wellyshen It does appear that it works properly in a CRA environment. So this probably isn't a bug with the library but maybe one with the browser's Intersection Observer implementation.
I did notice, that it looks like the state isn't reset properly?
The inView
says true
after the observe
is called and the new ref
has been set. As well as, the scrollDirection
is resetting to 'up'
even though I never scrolled up.
https://github.com/stramel/react-cool-inview-issue-495
from react-cool-inview.
@stramel That make sense, I will fix the scrollDirection part soon.
from react-cool-inview.
Going to close this issue in favor of a new one to show the other issues that I have found with scrollDirection
and inView
.
from react-cool-inview.
@stramel Thank you bro, your issues really helpful.
from react-cool-inview.
@stramel I copied your example to debug this issue with the latest version in my project (created by CRA) but I can not reproduce it, I'm not sure whether it only exists in the environment of the codesandbox (due to the issue of iframe) or not. Can it be reproduced in your project side?
from react-cool-inview.
@stramel The scrollDirection
should be reset in v2.0.1.
from react-cool-inview.
Thanks for the cool ๐ library! ๐๐ผ
from react-cool-inview.
Related Issues (20)
- Is there a way to trigger onLeave when begin to leave HOT 5
- scrollDirection reports wrong direction HOT 2
- README should include TypeScript examples HOT 2
- rootMargin must have pixel or percentage unit, but the โTrigger Animationsโ example uses a rootMargin of "-100px 0" which throws an error. HOT 3
- Ref not updating when conditionally applied HOT 7
- Custom Ref not checked before calling (un)observe HOT 2
- ScrollDirection isn't displaying the proper direction HOT 8
- inView is reporting incorrect value after loading more items until scroll. HOT 3
- Typescript typing wrong for observe HOT 2
- Demo image HOT 1
- Infinite rerenders when using ref={(el) => observe(el)} HOT 1
- Request support for multiple refs HOT 2
- SEO Question HOT 1
- Using cool inview only for src in a component HOT 1
- Observer not unmounted? HOT 19
- demo bug HOT 6
- No InView component HOT 1
- Infinite re-renders HOT 1
- Is this preact friendly? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-cool-inview.