ArrayBuffer is deprecated in XMLHttpRequest.send(). Use ArrayBufferView instead. about jquery-filedrop HOT 5 CLOSED

Its only a deprecation warning, but problematic to fix:

"Chrome 22 (current Canary) deprecates this feature by replacing it with sending ArrayBufferViews instead. JS Typed Arrays are just special ArrayBufferViews, so all this really means is that you can now send a typed array directly across the wire without touching its underlying buffer. This change is in match step with the recent updates to the XMLHttpRequest2 spec."

http://updates.html5rocks.com/2012/07/Arrived-xhr-send-ArrayBufferViews

try {
    if (XMLHttpRequest.prototype.sendAsBinary) {
        return;
    }
    XMLHttpRequest.prototype.sendAsBinary = function(datastr) {
      function byteValue(x) {
        return x.charCodeAt(0) & 0xff;
      }
      var ords = Array.prototype.map.call(datastr, byteValue);
      var ui8a = new Uint8Array(ords);
      this.send(ui8a.buffer);
    };
  } catch (e) {}

So instead of sending an ArrayBuffer on line 476

this.send(ui8a.buffer);

Remove the .buffer and send the typed array itself:

this.send(ui8a);

it removes the warning, but there isn't a check for older webkits that don't support sending ArrayBufferView..
possible solutions:

1. check for browser and version(problematic)
2. check on load if XMLHttpRequest.send accepts(ArrayBufferView)

Tested on:
Chrome Version 22.0.1229.94 m
Firefox 16.0.1

from jquery-filedrop.

Would a try() catch() around it work?

try {
    this.send(ui8a);
} catch(error) {
    this.send(ui8a.buffer);
}

from jquery-filedrop.

There isn't an error thrown but a console.warn() posted so nothing to catch..
Tested the removed '.buffer' code on Chrome 21 on OsX Lion and it silently failed.
No data was sent to the server.

Looks like it should be left in until the new W3C is widely accepted and you can rule out the older browser versions.
http://dvcs.w3.org/hg/xhr/raw-file/tip/Overview.html#dom-xmlhttprequest-send

There's probably a work around and it will haunt me for weeks...just short on time with current projects.

from jquery-filedrop.

Impacted by this as well... Is there a Modernizr feature detection for this?

from jquery-filedrop.

Not sure why, probably Array.prototype.map way already re-defined and extended by someone of the plugins I have already added on my page, but my Firefox 41.0.1 was blocking at:

var ords = Array.prototype.map.call(datastr, byteValue);

, that's why I modified the whole method to:

    XMLHttpRequest.prototype.sendAsBinary = function(datastr) {
        var nBytes = datastr.length, ui8a = new Uint8Array(nBytes);
        for (var nIdx = 0; nIdx < nBytes; nIdx++) {
          ui8a[nIdx] = datastr.charCodeAt(nIdx) & 0xff;
        }

      if ('ArrayBufferView' in window)
        this.send(ui8a);
      else
        this.send(ui8a.buffer);
    };

and this worked for me.

from jquery-filedrop.