Comments (2)
This was cleared in two steps. The 2nd step, which fixed the issue, is Commit dde8e9fa23bc. The dde8e9f commit removed this block, and folded the XOR into building outBlock
.
- if (xorBlock != NULLPTR)
- for (unsigned int n=0; n<ARIA::BLOCKSIZE; ++n)
- outBlock[n] ^= xorBlock[n];
The 1st commit, Commit 5250ab2bf2b0, removed the SIMD code since it was no longer needed due to the second commit.
I do not know why this fixed ARIA. The two codes should have been equivalent.
from cryptopp.
I do not know why this fixed ARIA. The two codes should have been equivalent.
ARIA had undefined behavior. Ugh!
The working area - m_w
- was too small. It should have been a SecWordBlock
with room for 28 word-sized elements. Instead it only had room for 17 elements. Arg!!!
Even more baffling, Valgrind never alerted to the problem.
Also see Commit d3d23002f607.
from cryptopp.
Related Issues (20)
- Crypto++ needs to support a fixed target HOT 2
- Poly1305 null pointer passed as argument 1 HOT 1
- Django cipher texts not matching Crypto++ cipher texts.
- destructor delete problem with own dialog program with MFC (Unicode/Use MFC in a Shared DLL) VS2015
- Memory leak in signature verification HOT 3
- repo too large, git clone often failed due to rpm connection timeout
- Compilation fails using MSYS2 CLANGARM64 toolchain
- Leak the Secret Key of Elgamal Encryption in Cryptopp via Rowhammer HOT 1
- ld.lld: error: duplicate symbol: CryptoPP::CallNewHandler()
- Add support for Elliptic Curves of Genus n (Hyperelliptic Curves)
- Infinite execution behavior in main branch
- Integer class errors
- ECP::ScalarMultiply() may seemingly miscompute for small scalars when using Ubuntu 20.04.6 LTS on 64-bit Intel CPUs HOT 6
- [x25519] donna function `curve25519_mult` generated different shared key HOT 1
- PGP signing key has expired
- Compilation issue with clang on X86
- Assertion failed: integer.cpp(3049):Integer HOT 1
- Warning in esign.cpp with 8.9.0 and gcc-14.1
- How can I compile for windows with mingw? HOT 1
- Warning when compiling universal binary (x86_64 + arm64) on macOS
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cryptopp.