Comments (4)
Hey happy to accept a PR for this!
I think there would be some UX work needed to accommodate that toggle so would recommend posting them here before making the PR
from socialify.
Thanks, @CryogenicPlanet. Sounds great. Sure, would be happy to post screenshots of the example UI.
I see you made this project as part of the MLH Fellowship. Awesome 🚀. I've just completed the Pre-Fellowship and we used Socialify for the header image of our repo. So easy to generate and work with.
I've never used TypeScript or GraphQL before so I've looked at the code and I think I'd need to update repoQuery.ts
with a new pullRequests
with a state of closed and add that to getOptionalConfig
of configHelper.ts
? Would that be along the right lines?
Thanks 😊
from socialify.
To an extent, you want to be able to get the state of both open and closed issues/prs separately so we can keep the default as open.
Feel free to play with the graphql explorer for GitHub here https://docs.github.com/en/graphql/overview/explorer. It makes it far easier to try things out.
So getOptionalConfig
would not be enough here, that just get the default configuration. You have to change the mergeConfig
You want to create a new parameter inside the optional types like description
has editable to decide if it is only open (default) or should include closed too. This can either be one toggle for both PRs and Issues or a different toggle for both, really depends on the UI
socialify/common/configHelper.ts
Lines 28 to 31 in beeba2d
You will have to add it to the QueryType
and ConfigType
too
socialify/common/types/queryType.ts
Lines 3 to 20 in beeba2d
Typescript should do its job and tell you everywhere QueryType is used and will have to change it to those places.
Happy to answer any other questions! Also don't worry about not knowing Graphql or Typescript, I didn't know it when we made this and barely knew typescript.
from socialify.
Closing due to inactivity.
from socialify.
Related Issues (20)
- FR: Private repo support HOT 4
- Next.js 12 Upgrade HOT 1
- [BUG] Not updating issues open HOT 5
- add Svelte icon HOT 1
- Bug: Image taking too long to update HOT 2
- Move to @vercel/og HOT 1
- Move GraphQL to Apollo and GraphQL Codegen HOT 2
- Import Google Font css HOT 2
- Next.js 13 Upgrade HOT 1
- URL Shortener HOT 3
- CJK Text Missing
- Support new line in description HOT 5
- Add border round HOT 3
- How to directly output .png format HOT 2
- PNG endpoint initWasm Bug HOT 6
- Is Socialify down? HOT 9
- Chinese character garbling HOT 1
- Add Kotlin logo HOT 3
- Add option for full white/black background HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from socialify.