Giter Club home page Giter Club logo

Comments (12)

wei avatar wei commented on May 20, 2024 2

image

mergable_state isn't clean due to GitHub workflow reporting error. At this time, pull does not merge when the PR isn't clean.

from pull.

wei avatar wei commented on May 20, 2024 1

Thanks for the report! If you don't mind, please leave one open and reply here when it happens again and I'll investigate. Thanks!!

from pull.

wei avatar wei commented on May 20, 2024 1

I don't think you have a way to check it. I'll just check it manually once it happens to another PR.

from pull.

wei avatar wei commented on May 20, 2024 1

Creating my own pull request without pull:

image

Everyone still showed up as participants: https://github.com/wei/generator-jhipster/pull/1

image

As you can see, this is something GitHub does automatically regardless of whether it's pull or a human creating the PR. and I don't think removing participants is possible through the API.

from pull.

wei avatar wei commented on May 20, 2024 1

Good idea. We can add a mergeUnstable boolean flag to the config then check it on this line.

const mergeableStatus = (incomingPR.mergeable && incomingPR.mergeable_state === 'clean') ? {

PR welcome.

from pull.

SudharakaP avatar SudharakaP commented on May 20, 2024 1

I've created the pull request. Please go through it and let me know if you see any issues. Since this is my first, might have done some things wrong πŸ˜„

from pull.

SudharakaP avatar SudharakaP commented on May 20, 2024

@wei : Thanks for the quick reply; I'll post here as soon as I see one again. Thanks much πŸ‘

from pull.

SudharakaP avatar SudharakaP commented on May 20, 2024

Investigating this a bit further, I have a strong feeling my issue might be same as #16. Currently I have 10 repos monitored by the pull app. Do you know any way to check whether the rate limit is hit? πŸ€”

from pull.

SudharakaP avatar SudharakaP commented on May 20, 2024

@wei : Hi, the problem is back. Here's the pr; SudharakaP/generator-jhipster#254. I am not going to merge this until you confirm you've done the analysis. Let me know as soon as you are done so since all the people in the conversation gets emails each time a checkin is made to the parent repo I think. πŸ˜„

Thanks much πŸ˜„

from pull.

SudharakaP avatar SudharakaP commented on May 20, 2024

If I may suggest another improvement (I am not certain if this is possible), is that everyone is not included in the conversation for the pull requests. Otherwise everyone gets the failure emails as pointed out to me by one of the people in that conversation. πŸ˜„

from pull.

SudharakaP avatar SudharakaP commented on May 20, 2024

@wei : Thanks for the analysis. Is it possible to make an option for the pull app to merge the changes even when the state is unclean? This will be helpful for people who doesn't have paid plans (such as myself) where github workflows can be run. πŸ˜„

EDIT: If you don't have time for this, I can try to contribute a pr as well. πŸ˜„

from pull.

SudharakaP avatar SudharakaP commented on May 20, 2024

Wonderful. Let me do the change today evening. πŸ˜„

from pull.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.