Add support for /knock command about weechat HOT 10 CLOSED

This command is not formally defined by an RFC, but is supported by most major IRC daemons.

Since this is not defined by a standard I don't think it should be added. Maybe we could write up a spec and send it to http://ircv3.org/.

Until then, if you want this command you can always do /alias knock quote knock and it will function as expected.

from weechat.

Freenode isn't following RFC so much either…

from weechat.

@Mkaysi I know, but waiting for a formal spec to be written and then implementing that means less work, cleaner code, and fewer issues once finished.

That being said, KNOCK does currently work in weechat. It doesn't doesn't do anything special for it, and it shouldn't, because the numerics used are different depending on who is implementing it and some ircds don't use numerics at all, and instead use notices.

Edit :: Also, one thing I've liked about weechat is that it doesn't seem to try to add things that don't have a spec written. Like WATCH, this was never implemented and weechat instead used /ison by default until MONITOR was implemented.

from weechat.

EDITED (2014-03-09 10:32 UTC)

I've been thinking about it, and I don't think /knock actually should be supported in the current form.
Other clients don't seem to handle it nicely, even if they have the command. I don't think it's used very often, either.

However, it not being standard alone isn't a reason not to implement it (consider /sajoin and quiet lists).

from weechat.

sajoin doesn't have numerics associated with it, and it doesn't have multiple different implementations.

I'm not against implementing knock, but there are several different implementations of it. Some ircds use a notice, others use a numeric, and some use both. Even the command changes depending on which ircd you are using. Some are KNOCK #chan :message and others are just KNOCK #chan

There is effort going into an ircv3.2 spec to standardize this. This will make it easier for clients to implement it, and until then I don't think it should be added.

from weechat.

I think it should be implemented. I understand the thought process of not wanting to do so because it isn't standardized, but I'd argue against that. Usability should be prioritized. Every major network I've had to use KNOCK on implements it, and most clients I've used have implemented it. If almost every other service/client is supporting it, why should we not? I feel like "stick to the spec" is the improper approach to handle IRC, because no major network or client sticks 100% to the spec.

And yes, people really do use /knock. I just had to, which is when I found out weechat doesn't support it :/.

from weechat.

I reopen the issue.
@shawn-smith : please ping me when KNOCK will be part of ircv3.x spec.

from weechat.

I need knock as well, is there a way to quote raw commands to the server?

from weechat.

yes, with /quote or use /set irc.network.send_unknown_commands

/alias add knock /quote knock $1

from weechat.

from weechat.