I guess that a different program design will be needed for your function "<a href="htt

Fix signal handler about weechat HOT 2 CLOSED

weechat commented on May 18, 2024

Fix signal handler

from weechat.

Comments (2)

flashcode commented on May 18, 2024

Hi,
Yes you're right, I have some issue (WeeChat locked) when the signal handler SIGHUP is called, for example under tmux when killing the pane (C-b x).
Here is the trace:

(gdb) bt
#0  __lll_lock_wait_private () at ../sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:95
#1  0x00007ff42f38ee32 in __GI___libc_malloc (bytes=140686744275712) at malloc.c:2923
#2  0x000055df0f8d978f in string_strndup (string=0x55df10bb9e60 "debug_dump", length=10) at /home/flashcode/src/weechat/dev/src/core/wee-string.c:86
#3  0x000055df0f8da0af in string_match (string=0x55df0f936549 "signal_sighup", mask=0x55df10bb9e60 "debug_dump", case_sensitive=0) at /home/flashcode/src/weechat/dev/src/core/wee-string.c:425
#4  0x000055df0f8ca96c in hook_signal_send (signal=0x55df0f936549 "signal_sighup", type_data=0x55df0f936542 "string", signal_data=0x0) at /home/flashcode/src/weechat/dev/src/core/wee-hook.c:2601
#5  0x000055df0f8981d2 in weechat_sighup () at /home/flashcode/src/weechat/dev/src/core/weechat.c:555
#6  <signal handler called>
#7  0x00007ff42f38ee1a in __GI___libc_malloc (bytes=1024) at malloc.c:2923
#8  0x000055df0f8dd916 in string_fprintf (file=0x55df11759680, data=0x55df0f94a9ce "%s%s = \"%s\"\n") at /home/flashcode/src/weechat/dev/src/core/wee-string.c:2412
#9  0x000055df0f8bb7b1 in config_file_write_option (config_file=0x55df10ccf150, option=0x55df10cde720) at /home/flashcode/src/weechat/dev/src/core/wee-config-file.c:2323
#10 0x000055df0f8bbe8d in config_file_write_internal (config_file=0x55df10ccf150, default_options=0) at /home/flashcode/src/weechat/dev/src/core/wee-config-file.c:2502
#11 0x000055df0f8bc058 in config_file_write (config_file=0x55df10ccf150) at /home/flashcode/src/weechat/dev/src/core/wee-config-file.c:2559
#12 0x000055df0f934232 in plugin_config_write () at /home/flashcode/src/weechat/dev/src/plugins/plugin-config.c:393
#13 0x000055df0f9307c7 in plugin_end () at /home/flashcode/src/weechat/dev/src/plugins/plugin.c:1332
#14 0x000055df0f898681 in weechat_end (gui_end_cb=0x55df0f9280a8 <gui_main_end>) at /home/flashcode/src/weechat/dev/src/core/weechat.c:713
#15 0x000055df0f8972c0 in main (argc=3, argv=0x7fffbfdab228) at /home/flashcode/src/weechat/dev/src/gui/curses/main.c:42

I'll make changes in signal handlers to do less things and prevent such locks.

from weechat.