Provide stable IDs for relay objects about weechat HOT 7 CLOSED

Actually the buffer lines have an id since WeeChat 3.8 (see issue #901), but I just realized it's not sent to weechat relay clients, so I'll add this.

I'll add identifiers in the other objects, starting with the buffers.

For nicks, is it really needed as well (as a nickname is unique in the nicklist)?

from weechat.

That's great, thanks!

For nicks, is it really needed as well (as a nickname is unique in the nicklist)?

Well, we are in fact detecting item movements when diffing the nicklist. So if you change your nick from foo to bar, you would see your name visually move upwards. Without IDs, you'd see one name disappear and another name appear. On the other hand, we should not delude ourselves into thinking that in reality anyone cares about nicklist animations...

from weechat.

I added unique identifier (called id) in buffers, that persists across /upgrade.

For nicks, this is a bit more complicated to add as-is, it can be added later, I plan to remove list of nicks in IRC plugin and use only buffer nicklist.

I keep issue open until it's implemented.

from weechat.

I would still prefer to have the nicklist as a plugin, in that context

from weechat.

If IRC plugin stores data on the core nicklist, it must be in core.
As all plugins are independent, IRC must not depend on another plugin to be able to run fine.

Maybe you could detail your idea @weechatter, and explain why for you it could be better to have a nicklist as plugin?

from weechat.

The concept of weechat is modular. buflist is an good example, it displays buffers instead of nicks but its a plugin.

from weechat.

I finally added the id in nicklist groups and nicks, so I close this issue.

This id is returned in the new API relay (see the spec here: https://specs.weechat.org/specs/2023-005-relay-http-rest-api.html#sub-resource-buffers--nicks).

Protocol "weechat" is unchanged, as it should be progressively replaced by the "api" protocol, and may even be removed in a future version (when no more clients are using it).

from weechat.