"irc_is_message_ignored" is calling the wrong callback about weechat HOT 4 CLOSED

Fixed in 4.0.8, 4.1.3, 4.2.0 (these 3 versions will be released soon).

from weechat.

Hi, indeed it's wrong, I'll fix ASAP.

By the way instead of catching IRC signals and using this info (which is specific to IRC plugin), I would recommend to use a function like hook_line, which is called when a line is displayed (by WeeChat or any plugin). If a line is displayed, that means it's not ignored by irc plugin (except if option irc.look.ignore_tag_messages is enabled, it's new in 4.2.0).

from weechat.

And I'll also add unit tests on IRC infos to prevent such bugs.

from weechat.

Thanks :)

I've considered hook_line, but between all the things I wanted to achieve, it seems most straightforward to intercept those messages and print them to buffer completely on my own, as I've described there

(I'm almost done making my own version of twitch.py, which does not call the http apis, but extracts and shows significantly more information from ircv3 tags and presents it better, including adding a lot of it to tags for versatile filtering and even post-tagging moderated messages to be (potentially) filtered out as well

The irc_filter thing is literally me reading about the shortcomings of twitch.py from it's desc and trying my best to work around those)

from weechat.