weddige / miniball Goto Github PK

Dear Konstantin,

thanks a lot for taking the time to create this package! Since I want to use it in my Linux distribution (Arch Linux), I decided to create a small package for it:

https://aur.archlinux.org/packages/python-miniball/

I would be happy if you could add this package to the README so that people know where to find the software.

Best,
Bastian

In miniball/src/miniballmodule.cpp:

// line 19, allocate variable points with
double** points = new double*[PyObject_Size(list)];
// line 70, delete variable points with:
delete points;

I think there should be an "[]" after keyword delete to free all the memory. But it's not a fatal problem because the function returns result immediately, and the compiler just throw warnings.

During the introduction of the Github Actions, there was an error while uploading the wheels to PyPI. To fix this, I set skip_existing:

This is not longer necessary and should be undone for the next release.

Hi,

I tried to install miniball by running setup.py. The installation goes with no errors but when I import miniball I get the following error:

Traceback (most recent call last):
File "", line 1, in
File "/Users/hebatalla/Downloads/miniball-master/miniball/init.py", line 2, in
import miniball.bindings
ModuleNotFoundError: No module named 'miniball.bindings'

Hi, I'm very new to this coding and python stuff. I'm trying to run an analysis for "idtrackerai" outputs via jupyter notebook. A module requires miniball installation for which I ran the following and got an error as below. Can someone walk me through the installation?

(base) C:\Users\Albert\Anaconda3\miniball-master>python "C:\Users\Albert\Anaconda3\miniball-master\setup.py" install
running install
running bdist_egg
running egg_info
writing Miniball.egg-info\PKG-INFO
writing dependency_links to Miniball.egg-info\dependency_links.txt
writing top-level names to Miniball.egg-info\top_level.txt
reading manifest file 'Miniball.egg-info\SOURCES.txt'
writing manifest file 'Miniball.egg-info\SOURCES.txt'
installing library code to build\bdist.win-amd64\egg
running install_lib
running build_py
running build_ext
building 'miniball.bindings' extension
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\HostX86\x64\cl.exe /c /nologo /Ox /W3 /GL /DNDEBUG /MD -IC:\Users\Albert\Anaconda3\include -IC:\Users\Albert\Anaconda3\include "-IC:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\ATLMFC\include" "-IC:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\include" /EHsc /Tpsrc/miniballmodule.cpp /Fobuild\temp.win-amd64-3.7\Release\src/miniballmodule.obj
miniballmodule.cpp
c:\users\albert\anaconda3\include\pyconfig.h(59): fatal error C1083: Cannot open include file: 'io.h': No such file or directory
error: command 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\HostX86\x64\cl.exe' failed with exit status 2

would it be possible to publish some wheels for all three major platforms (not just windows) on PyPI ?
It may be possible to avoid making one wheel per Python version using Py_LIMITED_API

For example see how this was done in casa-formats-io: radio-astro-tools/casa-formats-io#50

It seems that this module, when using something like this:

miniball.Miniball([val1, val2, val3, etc..]).squared_root()

Uses about 300KiB of memory and doesn't free it, after it finished running, which means when you are trying to do hundreds of thousands of iterations over it, the system will run out of memory and simply kill the process.