Giter Club home page Giter Club logo

Comments (10)

ungoldman avatar ungoldman commented on May 22, 2024

Currently there are three actions for each torrent in the list -- chromecast, play, and delete.

The video functionality is cool but (currently) only works for single video files. I think a start/pause download button (which may conflict visually with the video play button) is more important since it applies to all types of downloads. I think it should also be more prominent in the visual hierarchy than the video controls.

So here is an emoji mockup:

Current:

title 📶 ▶️
0️⃣ % - 0️⃣ Peers - 0️⃣ B/s - 0️⃣ B/s

Proposed changes:

title ▶️
📶 🎦
0️⃣ % - 0️⃣ Peers - 0️⃣ B/s - 0️⃣ B/s

  • Download controls (first row) are available for all torrents
    • play button turns to pause when active
  • Playback controls (second row) are only visible for supported files

If this makes sense to you I can work on implementing it.

from webtorrent-desktop.

ChrisMorrisOrg avatar ChrisMorrisOrg commented on May 22, 2024

Fullscreen is a bit of an issue in OS X at the moment, the back/forward and add torrent buttons are not accessible in fullscreen mode.

Perhaps having those buttons move into the chrome in fullscreen mode would work better?

from webtorrent-desktop.

dcposch avatar dcposch commented on May 22, 2024

@ChrisMorrisOrg i think that's fine. you can hit ESC once to get out of fullscreen, then ESC again (or click back) to return to the torrent list

the add button appears only when you're in the torrent list, not while you're playing a video

from webtorrent-desktop.

feross avatar feross commented on May 22, 2024

@dcposch What does the app look like on Ubuntu now? Can we check off "make it look nice on Ubuntu?" from the list?

from webtorrent-desktop.

rom1504 avatar rom1504 commented on May 22, 2024

It looks okay in kubuntu currently, apart from #51

webtorrent app

from webtorrent-desktop.

giuscri avatar giuscri commented on May 22, 2024

I'd add that pressing the space bar should pause the video

from webtorrent-desktop.

dcposch avatar dcposch commented on May 22, 2024

@giuscri good call, i'll make it do that

from webtorrent-desktop.

dcposch avatar dcposch commented on May 22, 2024

@feross it looks good in standard Ubuntu. I commented on #51, I think it's NBD

from webtorrent-desktop.

feross avatar feross commented on May 22, 2024

Looks good on Windows.

screen shot 2016-03-07 at 6 20 44 pm

I just discovered some minor UX issues:

  • Don't resize window when player is opened if window is maximized. (Didn't find this because OS X doesn't have the notion of maximized windows, only fullscreen.)
  • Try hiding top menu buttons until user presses Alt
  • Leave fullscreen when player closes. (all OSs)

from webtorrent-desktop.

feross avatar feross commented on May 22, 2024

Going to close this issue now.

@dcposch There's already an issue open on the webtorrent repo for the one remaining item.

'sequential' piece selection should be a better citizen: webtorrent/webtorrent#375

from webtorrent-desktop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.