Giter Club home page Giter Club logo

Comments (6)

alexander-akait avatar alexander-akait commented on June 2, 2024

It is potential unsafe, that is why it was changed, you can have the same URL for different files here, why you need it?

from webpack-dev-middleware.

just-boris avatar just-boris commented on June 2, 2024

As in my demo repository, the output is in two separate subfolders (/foo and /bar), so there will be no files collision. If output subfolders overlap (/foo and /foo/bar), that's a problem in any way because webpack build would overwrite the files.

Dev server here is a reflection of the output of the normal build, does not need any additional validations

from webpack-dev-middleware.

alexander-akait avatar alexander-akait commented on June 2, 2024

In theory we can implement overriding outputPath, so you can override it for any numbers of compiles, I don't want to support it by default, because it is really unsafe

from webpack-dev-middleware.

just-boris avatar just-boris commented on June 2, 2024

How is this more unsafe than the webpack build output, which produces the same files on the disk? Does it print a warning when overwriting a file from another compiler?

In any way, would you accept a PR adding contentBase property to the middleware options? (I think, it should belong here)

from webpack-dev-middleware.

alexander-akait avatar alexander-akait commented on June 2, 2024

How is this more unsafe than the webpack build output, which produces the same files on the disk? Does it print a warning when overwriting a file from another compiler?

The main problem here is the same URLs, you can potential create situation when the same URL returns different content, but if you use different directories (like in your example) you should not have these problems

In any way, would you accept a PR adding contentBase property to the middleware options? (I think, it should belong here)

It is not related to contentBase, I think we need better name here, but yes, PR welcome, we will improve name in a PR

from webpack-dev-middleware.

alexander-akait avatar alexander-akait commented on June 2, 2024

les't close in favor #979, we want to move webpack-dev-middleware into webpack-dev-server (monorepo), so we do some cleaup before moving issues, yeah, I agree, we don't have good support for multi compiler mode and share assets between them

from webpack-dev-middleware.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.