Comments (2)
Tbh we would love a benchmark system to can hook into the one we just added on webpack/webpack if you could highlight the perf wins we will take a PR for sure
from tapable.
Welllll I just discovered that arguments
inside a function is not really an array. In fact it seems that the only properties arguments
and Array.prototype
have in common is Symbol.iterator
and length
. Array.prototype
doesn't even exist in its [[Prototype]]
chain so the current code is entirely necessary as arguments.slice(..)
=== TypeError
;) .
With that being said, but still on the topic of perf, some research indicates that a good ol' for (...)
loop will be considerably faster than Array.prototype.forEach
so I wouldn't mind swapping this out. If a simple PR doing just this would be accepted I wouldn't mind making it. However if you want to a benchmark system to hook into the webpack source I'd be very interested in that, but would probably need some help getting off the ground as I'm not yet familiar with the (new?) benchmarking system in webpack source.
from tapable.
Related Issues (20)
- Re-order taps after tap function is called to guarantee old taps are in correct order HOT 3
- what is the idea of reassignment a class propery
- AsyncParallelBailHook, I use tapAsync/callAsync, it doesn't work as expected HOT 3
- DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead HOT 2
- Not compatible with webpack v5 HOT 1
- Why hooks constructor can not use arguments like readme.md said HOT 1
- has `hooks.hookName.taps` been not recommanded? HOT 3
- i use tapable singlely in my project,but in my webpack,"node_modules" folders has no compile. HOT 4
- AsyncHook in types HOT 6
- May I ask some question?
- Is the new Function performance really good? HOT 13
- Is it a BUG? callback of tapAsync not work in AsyncSeriesLoopHook HOT 2
- is there an way to intercept waterfall hook result ?
- Why not put _resetCompilation in this.call HOT 1
- .tap() `before` parameter do not respects existing befores HOT 1
- TS Error HOT 3
- `context` property for interceptor is un-typed
- Re-order hooks
- [Bug] Async hook doesn't catch error when reject a falsy value HOT 6
- Facing TypeError: Cannot read properties of undefined (reading 'tap') HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tapable.