README documentation - first example - image.png needs to be image.jpg about html-loader HOT 6 CLOSED

Hi, seems to be my bad here, but can you explain little more detailed what threw off please :)

from html-loader.

From the README doc:

<!-- file.html -->
<img src="image.png" data-src="image2x.png" >

Notice the src attribute points to image.png. I believe it should point to image.jpg because ...
In the proceeding example:

require("html!./file.html");

// => '<img src="http://cdn.example.com/49eba9f/a992ca.jpg"
//         data-src="image2x.png">'

The src attribute is updated accordingly, and it has a jpg extension. That's what threw me off, because originally it had a png extension.

from html-loader.

kk 👍 i will make the examples consistent

from html-loader.

Hi,

I believe that only the compiled example should be changed since after this instance in the code it clearly always references png extension with the same hash (a992ca).

<!-- file.html -->
<img src="image.png" data-src="image2x.png" >

require("html!./file.html");

// => '<img src="http://cdn.example.com/49eba9f/a992ca.jpg" /* Error is here */
//         data-src="image2x.png">'

require("html?attrs=img:data-src!./file.html");

// => '<img src="image.png" data-src="data:image/png;base64,..." >'

require("html?attrs=img:src img:data-src!./file.html");
require("html?attrs[]=img:src&attrs[]=img:data-src!./file.html");

// => '<img  src="http://cdn.example.com/49eba9f/a992ca.png"        
//           data-src="data:image/png;base64,..." >'

I've made the changes in #86 if that's ok with you @michael-ciniawsky.

from html-loader.

Pulled it in, LGTM, let me know if any others changes.

from html-loader.

@andreicek thx 👍

from html-loader.