Giter Club home page Giter Club logo

Comments (10)

lettertwo avatar lettertwo commented on June 19, 2024

I think this issue may apply to other loaders that try to resolve paths from embedded urls as well, such as css-loader and less-loader.

from html-loader.

lettertwo avatar lettertwo commented on June 19, 2024

I think my expectation of how this would work is that the 'root-relative' urls would be resolved against the module root(s). Basically, instead of prepending with ./, stripping the leading / from the the url.

In fact, making the following change to urlToRequire seems to solve my use case:

function urlToRequire(url) {
    if(/^~/.test(url))
        return url.substring(1);
    else if(/^\//.test(url))
        return url.replace(/^\/+/, '');
    else
        return "./"+url;
}

This also seems relevant to the similar functionality in css-loader.

from html-loader.

jhnns avatar jhnns commented on June 19, 2024

Mhmmm ... I'd expect absolute paths being resolved relative to resolve.root.

from html-loader.

sokra avatar sokra commented on June 19, 2024

I thought of a query parameter root:

  • root not set: Root-relative urls are threaded like absolute urls and are not translated.
  • root set: root is prepended to root-relative urls and they are translated

from html-loader.

jhnns avatar jhnns commented on June 19, 2024

Why is it a query parameter? Is it likely to have different roots?

from html-loader.

lettertwo avatar lettertwo commented on June 19, 2024

It doesn't seem very likely that there would be different roots for a given build, but it does seem likely that the root would need to be configured (and differently from resolve.root.) Is there a better way to do that?

from html-loader.

lettertwo avatar lettertwo commented on June 19, 2024

Since #8 is now closed, i think this one can be closed, too!

from html-loader.

jhnns avatar jhnns commented on June 19, 2024

How does the root-query param work?

from html-loader.

sokra avatar sokra commented on June 19, 2024

https://github.com/webpack/html-loader#root-relative-urls

from html-loader.

jhnns avatar jhnns commented on June 19, 2024

K thx

from html-loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.