Error when command is executed outside bin/ directory. about console-parallelization HOT 16 CLOSED

Something's not right... v1.2.0 and v1.2.1 are tagged on master, while v1.2.2 is tagged on 1.x (and points to the same commit as v1.1.0), while in the release notes it says that it contains #48, which however was merged into master and not into 1.x.

So when users run composer update, they lose the changes from master that were already in v1.2.0 and v1.2.1.

What should have been done instead is to merge 1.x into master and release this as v1.2.2, I suppose.

from console-parallelization.

I agree
Actually https://github.com/webmozarts/console-parallelization/blob/master/composer.json#L18 is causing the composer conflict now.

from console-parallelization.

@theofidry any updates on that, actually it would be quite urgent 😐 Thanks in advance!

from console-parallelization.

Agreed the console path detection could be better, I don't like the current one either

from console-parallelization.

@theofidry What if we move that line
https://github.com/webmozarts/console-parallelization/blob/1.x/src/Parallelization.php#L379

into a separate method? I can provide a PR if you agree...

from console-parallelization.

that would make sense 👍

from console-parallelization.

that would make sense 👍

Done.

from console-parallelization.

Closed via #43

from console-parallelization.

Hi @theofidry,

Is there a reason this was dropped in 1.2.x?

from console-parallelization.

Hi @theofidry,

Is there a reason this was dropped in 1.2.x?

I think in 1.2.1. you tagged based on the master, but it should be tagged based on version 1.x?
The method is important as it is overriden in Pimcore.

from console-parallelization.

Sorry for the late response, indeed I tagged the wrong branch corrected with 1.2.2

from console-parallelization.

@theofidry are you going to fix the v1.2.2 release, or should we add a conflict to our composer.json ?

  "conflict": {
    "webmozarts/console-parallelization": "1.2.2",

from console-parallelization.

I'll try to have a look next week I'm a bit under water atm

from console-parallelization.

Ok looks like things got quite messed up: quite a bit of work was introduced on master and master was accidentally released as 1.x. I'll merge back master to 1.x and do a new release. Technically this is introducing BC breaks but given the relatively low usage and because that problematic release has been out for so long I think it's an acceptable solution

from console-parallelization.

@theofidry Thanks a lot for looking into this, just tested and I can confirm all works now. 👍

from console-parallelization.

As of 2.x, by default the current script path will be taken instead of $cwd/bin/console which be more robust and also work outside of a Symfony context.

from console-parallelization.